-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 update kubebuilder core dependencies for k8s 1.25 #2954
🌱 update kubebuilder core dependencies for k8s 1.25 #2954
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Just a TODO: we need to bump controller-tools too, if it gets released soon.
We could wait for a day, if it gets delayed please feel free to merge it.
@varshaprasad96 would it be worth it to consider bumping controller-tools to the latest master commit in the meantime? |
ecc670c
to
e5edb70
Compare
Signed-off-by: Bryce Palmer <[email protected]>
3dcc69b
to
f8e5d2b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HI @everettraven, Controller-tools is released and we can do the bump in a follow-up. So, I think it is OK to go. |
Description of the change
go.mod
andgo.sum
to bump the k8s dependencies to support 1.25Motivation for the change
The scaffolds were updated to have dependencies bumped to k8s 1.25 but the core Kubebuilder go.mod dependencies were not. This PR fixes that.
Open Questions