feat: add sha256sums for kind binaries #2336

viveksyngh · 2021-06-27T05:48:42Z

Add sha256sum file for kind binaries build as a part of release process

k8s-ci-robot · 2021-06-27T05:48:50Z

Welcome @viveksyngh!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-06-27T05:48:50Z

Hi @viveksyngh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

viveksyngh · 2021-06-27T05:52:01Z

/assign @BenTheElder

viveksyngh · 2021-06-27T05:53:47Z

/kind feature

xinydev · 2021-06-27T08:19:45Z

hack/release/build/cross.sh

@@ -48,3 +48,6 @@ export GOOS=linux GOARCH=arm64
 export GOOS=linux GOARCH=ppc64le
 EOF
 )
+
+# add sha256 for binaries
+for f in ${REPO_ROOT}/bin/kind-*; do shasum -a 256 $f > $f.sha256sum; done


the original output for shasum is something like hashValue fileName, I think it only needs the hash value here?

https://github.com/kubernetes/kompose/blob/0b331d9e5dede975d62ca382b2dd7dff89019f6e/script/release.sh#L243

how do you know the filaname to check it with the command?

[aojea@aojea-laptop ~]$ shasum -a 256 ifac.go > ifac.sha [aojea@aojea-laptop ~]$ sha256sum -c ifac.sha ifac.go: OK [aojea@aojea-laptop ~]$ cp ifac.sha ifac.shaonly [aojea@aojea-laptop ~]$ vi ifac.shaonly #removed the filename [aojea@aojea-laptop ~]$ sha256sum -c ifac.shaonly sha256sum: ifac.shaonly: no properly formatted SHA256 checksum lines found

You are right, it is not easy to check.

however,I found that we have a lot of current tar files are only have the hash value,I'm just curious what is the reason for this.

➜ ~ gsutil cat gs://kubernetes-release/release/v1.21.0-alpha.0/kubernetes-test-windows-amd64.tar.gz.sha256 e3b8a57d0bba4665f54874e4478bf2b360254314a482f4ba36f15ce228c561b7% ➜ ~ gsutil cat gs://kubernetes-release/release/v1.21.0-alpha.0/kubernetes-src.tar.gz.sha256 7eaf8fa1aa03afead4292d1e10dbc839439b4cd45a5a749bac242f8cf0040f45%

I find a shell script using the command to check.

not an expert here, I always used the hash filename format, that is what shasum reports directly

I have also used hash filename format for one of the CLI in the past. Not sure what benefit other approach has.

aojea · 2021-06-27T17:39:59Z

/ok-to-test

aojea · 2021-06-27T17:48:10Z

the verify job fails

In ./hack/release/build/cross.sh line 53:
for f in ${REPO_ROOT}/bin/kind-*; do shasum -a 256 $f > $f.sha256sum; done
         ^----------^ SC2231: Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
                                                   ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                        ^-- SC2086: Double quote to prevent globbing and word splitting.

viveksyngh · 2021-06-28T02:52:58Z

/test pull-kind-verify

aojea · 2021-06-28T10:40:59Z

hack/release/build/cross.sh

@@ -48,3 +48,6 @@ export GOOS=linux GOARCH=arm64
 export GOOS=linux GOARCH=ppc64le
 EOF
 )
+
+# add sha256 for binaries
+for f in "${REPO_ROOT}"/bin/kind-*; do shasum -a 256 "$f" > "$f".sha256sum; done


don't use the oneliner and keep the last line, is easier to read

Suggested change

for f in "${REPO_ROOT}"/bin/kind-*; do shasum -a 256 "$f" > "$f".sha256sum; done

for f in "${REPO_ROOT}"/bin/kind-*; do

shasum -a 256 "$f" > "$f".sha256sum

done

hmm this adds the whole path to the generated file, I think that we have to cd first in the folder

cd "${REPO_ROOT}"/bin for f in kind-*; do shasum -a 256 "$f" > "$f".sha256sum done

yup it was adding full path. I have updated that to change to the directory and then run sha command.

- Add sha256sum file for kind binaries build as a part of release process

aojea · 2021-06-28T13:04:59Z

/lgtm
thanks
/assign @BenTheElder

BenTheElder

/lgtm
/approve
/hold
thanks!

BenTheElder · 2021-06-28T18:31:15Z

hack/release/build/cross.sh

@@ -48,3 +48,9 @@ export GOOS=linux GOARCH=arm64
 export GOOS=linux GOARCH=ppc64le
 EOF
 )
+
+# add sha256 for binaries
+cd "${REPO_ROOT}"/bin


TODO: refactor to not need cd EDIT: at least in the current shell scope, we could perhaps do this bit in a subshell or see if there's some other approach to manipulating the output.
TODO: update loop to ignore files with .sha256sum extension.

k8s-ci-robot · 2021-06-28T18:32:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, viveksyngh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2021-06-29T18:57:27Z

/hold cancel
we can iterate later, thank you!

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2021

k8s-ci-robot requested review from aojea and krzyzacy June 27, 2021 05:48

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2021

k8s-ci-robot assigned BenTheElder Jun 27, 2021

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2021

xinydev reviewed Jun 27, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2021

viveksyngh force-pushed the add-sha-for-binaries branch from b5e477d to 00b9664 Compare June 28, 2021 02:39

viveksyngh force-pushed the add-sha-for-binaries branch from 00b9664 to 651a50d Compare June 28, 2021 03:20

aojea reviewed Jun 28, 2021

View reviewed changes

viveksyngh force-pushed the add-sha-for-binaries branch from 651a50d to 85a6d13 Compare June 28, 2021 11:01

feat: add sha256sums for kind binaries

6937f75

- Add sha256sum file for kind binaries build as a part of release process

viveksyngh force-pushed the add-sha-for-binaries branch from 85a6d13 to 6937f75 Compare June 28, 2021 12:45

k8s-ci-robot assigned aojea Jun 28, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021

BenTheElder approved these changes Jun 28, 2021

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2021

k8s-ci-robot merged commit 5dbdf31 into kubernetes-sigs:main Jun 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add sha256sums for kind binaries #2336

feat: add sha256sums for kind binaries #2336

viveksyngh commented Jun 27, 2021 •

edited

Loading

k8s-ci-robot commented Jun 27, 2021

k8s-ci-robot commented Jun 27, 2021

viveksyngh commented Jun 27, 2021

viveksyngh commented Jun 27, 2021

xinydev Jun 27, 2021

aojea Jun 27, 2021

xinydev Jun 28, 2021 •

edited

Loading

aojea Jun 28, 2021

viveksyngh Jun 28, 2021

aojea commented Jun 27, 2021

aojea commented Jun 27, 2021

viveksyngh commented Jun 28, 2021 •

edited

Loading

aojea Jun 28, 2021

viveksyngh Jun 28, 2021

aojea Jun 28, 2021

viveksyngh Jun 28, 2021

aojea commented Jun 28, 2021

BenTheElder left a comment

BenTheElder Jun 28, 2021 •

edited

Loading

k8s-ci-robot commented Jun 28, 2021

BenTheElder commented Jun 29, 2021

feat: add sha256sums for kind binaries #2336

feat: add sha256sums for kind binaries #2336

Conversation

viveksyngh commented Jun 27, 2021 • edited Loading

k8s-ci-robot commented Jun 27, 2021

k8s-ci-robot commented Jun 27, 2021

viveksyngh commented Jun 27, 2021

viveksyngh commented Jun 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xinydev Jun 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea commented Jun 27, 2021

aojea commented Jun 27, 2021

viveksyngh commented Jun 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea commented Jun 28, 2021

BenTheElder left a comment

Choose a reason for hiding this comment

BenTheElder Jun 28, 2021 • edited Loading

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 28, 2021

BenTheElder commented Jun 29, 2021

viveksyngh commented Jun 27, 2021 •

edited

Loading

xinydev Jun 28, 2021 •

edited

Loading

viveksyngh commented Jun 28, 2021 •

edited

Loading

BenTheElder Jun 28, 2021 •

edited

Loading