Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha256sums for kind binaries #2331

Closed
cokegen opened this issue Jun 25, 2021 · 5 comments · Fixed by #2336
Closed

sha256sums for kind binaries #2331

cokegen opened this issue Jun 25, 2021 · 5 comments · Fixed by #2336
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@cokegen
Copy link

cokegen commented Jun 25, 2021

What would you like to be added: sha256sums / gpg signatures for kind binaries

Why is this needed: some basic form of verification at least for the kind binaries would be good to have, hashes, gpg signatures, etc.

@cokegen cokegen added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2021
@BenTheElder
Copy link
Member

BenTheElder commented Jun 25, 2021

We can and should definitely add shasums to the binaries so download integrity can be checked.

I don't think the Kubernetes project currently has a solution for signing, if/when it does we'll follow suit here.

kind binary builds should be reproducible at least though, so anyone can vet that the binary + sha reflects the sources fairly easily (clone the sources, run the build and compare, they should match, if not that's a regression we should fix).


This should make a pretty good starter issue for anyone interested, basically update this script which we run as part of the release process to produce a ${file_name}.sha256sum file containing the hash of ${file_name} for each build output file after we build:

https://github.com/kubernetes-sigs/kind/blob/c64d7644516f7214c063b4cee5c324fd14e6dd1e/hack/release/build/cross.sh

Then when we release these will be alongside the binary outputs and we'll upload them as well

/help
/good-first-issue
/sig testing

@k8s-ci-robot
Copy link
Contributor

@BenTheElder:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

We can and should definitely add shasums to the binaries so download integrity can be checked.

I don't think the Kubernetes project currently has a solution for signing, if/when it does we'll follow suit here.

kind binary builds should be reproducible at least though, so anyone can vet that the binary + sha reflects the sources fairly easily.


This should make a pretty good starter issue for anyone interested, basically update this script which we run as part of the release process to produce a ${file_name}.sha256sum file containing the hash of ${file_name} for each build output file after we build:

https://github.com/kubernetes-sigs/kind/blob/c64d7644516f7214c063b4cee5c324fd14e6dd1e/hack/release/build/cross.sh

Then when we release these will be alongside the binary outputs and we'll upload them as well

/help
/good-first-issue
/sig testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 25, 2021
@BenTheElder BenTheElder added this to the v0.12.0 milestone Jun 25, 2021
@viveksyngh
Copy link
Contributor

/assign

@asher-lab
Copy link

hello @viveksyngh is there a readme or some place where the sha256sum/sha512sum are published? like from kubernetes where the sha512 sum are in there readme file? https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.27.md thanks

@BenTheElder
Copy link
Member

They're alongside the release binaries. See "assets" at the bottom of e.g. https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0, which is standard for github hosted releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants