Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for CSI server side error count #1227

Merged
merged 5 commits into from
May 25, 2023
Merged

Add metrics for CSI server side error count #1227

merged 5 commits into from
May 25, 2023

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented May 15, 2023 •
edited by sunnylovestiramisu
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
It adds an CSI server side error count metric for PDCSI and Hyperdisk volumes
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add metrics for CSI server side error count

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sneha-at. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from amacaskill and leiyiz May 15, 2023 22:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2023
@tyuchn
Copy link
Contributor

tyuchn commented May 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2023
@sunnylovestiramisu
Copy link
Contributor

/ok-to-test

@Sneha-at Sneha-at force-pushed the hyperdisk_slo_sli branch from 0839962 to b075d44 Compare May 16, 2023 20:12
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023
@Sneha-at Sneha-at force-pushed the hyperdisk_slo_sli branch from b075d44 to 77b9945 Compare May 16, 2023 20:18
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2023
@Sneha-at Sneha-at marked this pull request as draft May 16, 2023 20:42
@Sneha-at
Copy link
Contributor Author

/retest

@Sneha-at
Copy link
Contributor Author

/retest

@Sneha-at
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2023
msau42
msau42 reviewed May 25, 2023
View reviewed changes
@msau42
Copy link
Contributor

msau42 commented May 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@sunnylovestiramisu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sneha-at, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit c22a812 into kubernetes-sigs:master May 25, 2023
@Sneha-at
Copy link
Contributor Author

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link

@Sneha-at: only kubernetes-sigs org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunnylovestiramisu
Copy link
Contributor

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sunnylovestiramisu: new pull request created: #1237

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 25, 2023
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request May 26, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request May 26, 2023
@k8s-ci-robot
Merge pull request #1240 from sunnylovestiramisu/automated-cherry-pic…
ddcd135 
…k-of-#1232-#1227-upstream-release-1.9

Automated cherry pick of #1150 #1232 #1227 on release-1.9.
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request May 30, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 1, 2023
@k8s-ci-robot
Merge pull request #1244 from sunnylovestiramisu/automated-cherry-pic…
256c7c3 
…k-of-#1150-#1232-#1227-upstream-release-1.8

Automated cherry pick of #1150: fix bug where volume cloning topology requirements are
#1232: Use errors.As so we can detect wrapped errors, and check for
#1227: Adding new metric pdcsi_operation_errors to fetch error
@Sneha-at Sneha-at mentioned this pull request Jun 16, 2023
Merged
@Sneha-at Sneha-at mentioned this pull request Jun 30, 2023
Merged
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jul 21, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2023
@k8s-ci-robot
Merge pull request #1305 from sunnylovestiramisu/automated-cherry-pic…
3d1fd21 
…k-of-#1101-#1227-#1296-upstream-release-1.7

Automated cherry pick of #1101: Add provisionedThroughput for hyperdisk
#1227: Adding new metric pdcsi_operation_errors to fetch error
#1296: emit metrics even for success scenarios
@leiyiz leiyiz mentioned this pull request Aug 2, 2023
Closed
@Sneha-at Sneha-at mentioned this pull request Aug 17, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@amacaskill amacaskill Awaiting requested review from amacaskill

@leiyiz leiyiz Awaiting requested review from leiyiz

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sneha-at @k8s-ci-robot @tyuchn @sunnylovestiramisu @msau42 @k8s-infra-cherrypick-robot