Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provisionedThroughput for hyperdisk-throughput #1101

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Add provisionedThroughput for hyperdisk-throughput #1101

merged 3 commits into from
Jan 11, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Dec 19, 2022 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Support hyperdisk-throughput with provisionedThroughput

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

TBD for hyperdisk-throughput public documentation

Add provisionedThroughput for hyperdisk

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2022
@sunnylovestiramisu
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2023
@sunnylovestiramisu sunnylovestiramisu force-pushed the hyperdisk branch 3 times, most recently from a33dd82 to ad415f7 Compare January 4, 2023 18:34
@mattcary
Copy link
Contributor

mattcary commented Jan 4, 2023

It looks like the throughput tests are failing because the api isn't public yet:

W1219 23:40:53.396] pkg/gce-cloud-provider/compute/gce-compute.go:438:3: unknown field 'ProvisionedThroughput' in struct literal of type "google.golang.org/api/compute/v1".Disk

We should not run with the throughput storageclass, just extreme, until throughput is released.

@sunnylovestiramisu sunnylovestiramisu force-pushed the hyperdisk branch 2 times, most recently from de11f39 to 7c8f9fb Compare January 11, 2023 01:20
@sunnylovestiramisu sunnylovestiramisu force-pushed the hyperdisk branch 8 times, most recently from bf3445b to e9054ac Compare January 11, 2023 19:45
@sunnylovestiramisu sunnylovestiramisu marked this pull request as ready for review January 11, 2023 22:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from msau42 January 11, 2023 22:28
@sunnylovestiramisu
Copy link
Contributor Author

/assign @mattcary

@mattcary
Copy link
Contributor

/lgtm
/approve

\o/

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 900f5f7 into kubernetes-sigs:master Jan 11, 2023
@msau42 msau42 mentioned this pull request Jan 30, 2023
Closed
@leiyiz leiyiz mentioned this pull request Feb 13, 2023
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 14, 2023
This was referenced May 26, 2023
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 30, 2023
@k8s-ci-robot
Merge pull request #1241 from sunnylovestiramisu/automated-cherry-pic…
d630e83 
…k-of-#1079-#1101-upstream-release-1.8

Automated cherry pick of #1079: Add provisionedIops for pd-extreme
#1101: Add provisionedThroughput for hyperdisk
@mattcary mattcary mentioned this pull request Jun 14, 2023
Closed
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2023
@k8s-ci-robot
Merge pull request #1243 from sunnylovestiramisu/automated-cherry-pic…
cc2fea0 
…k-of-#1079-#1101-#1128-upstream-release-1.7

Automated cherry pick of #1079: Add provisionedIops for pd-extreme #1128: Change iops params directly convert string to int64
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jul 21, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2023
@k8s-ci-robot
Merge pull request #1305 from sunnylovestiramisu/automated-cherry-pic…
3d1fd21 
…k-of-#1101-#1227-#1296-upstream-release-1.7

Automated cherry pick of #1101: Add provisionedThroughput for hyperdisk
#1227: Adding new metric pdcsi_operation_errors to fetch error
#1296: emit metrics even for success scenarios
@sunnylovestiramisu sunnylovestiramisu deleted the hyperdisk branch March 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz Awaiting requested review from leiyiz

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@msau42 msau42 Awaiting requested review from msau42

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunnylovestiramisu @k8s-ci-robot @mattcary