Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global destroyer timeouts #423

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add global destroyer timeouts #423

merged 1 commit into from
Oct 14, 2021

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Oct 8, 2021 •
edited
Loading

  • Destroyer context added, with cancellation test.
  • Added a few logs to help with debugging test failures

After this lands, we can follow up with...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @karlkfi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 8, 2021
This was referenced Oct 8, 2021
Closed
Closed
@seans3
Copy link
Contributor

seans3 commented Oct 8, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2021
@karlkfi karlkfi force-pushed the karl-global-timeout branch from 0049e0c to cc735b4 Compare October 11, 2021 17:46
@karlkfi karlkfi changed the title Add global applier & destroyer timeouts [WIP] Add global applier & destroyer timeouts Oct 11, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2021
@karlkfi
Copy link
Contributor Author

karlkfi commented Oct 11, 2021

Extracted a bunch of the testing changes to #429

I'll rebase this PR, once that one merges.

@karlkfi karlkfi force-pushed the karl-global-timeout branch from cc735b4 to b96f060 Compare October 12, 2021 22:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 12, 2021
@karlkfi karlkfi changed the title [WIP] Add global applier & destroyer timeouts Add global destroyer timeouts Oct 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021
@karlkfi
Copy link
Contributor Author

karlkfi commented Oct 12, 2021

Pulled out the cmd updates. I'll make a new PR for that.

@karlkfi
Add global destroyer timeout
31679a6 
- Destroyer context added, with cancel test.
- Fix Applier cancel test not using specified timeouts.
- Added a few logs to help with debugging test failures
@karlkfi karlkfi force-pushed the karl-global-timeout branch from b96f060 to 31679a6 Compare October 13, 2021 00:43
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2021
@karlkfi
Copy link
Contributor Author

karlkfi commented Oct 13, 2021

Found a few bugs with the ApplierCancel test while I was cleaning this up. Fixed those too.

@mortent
Copy link
Member

mortent commented Oct 13, 2021

/lgtm

@mortent mortent requested review from seans3 and removed request for barney-s October 13, 2021 20:34
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2021
mortent
mortent approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mortent mortent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit a299abd into kubernetes-sigs:master Oct 14, 2021
@karlkfi karlkfi deleted the karl-global-timeout branch October 19, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent mortent approved these changes

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@seans3 seans3 Awaiting requested review from seans3

Assignees

@mortent mortent

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlkfi @k8s-ci-robot @seans3 @mortent