[WIP] Add support for external dependencies #412

karlkfi · 2021-09-29T05:13:16Z

Add Defaulter Mutator to update objects early to inherit the target resource namespace for SourceRef in apply-time-mutation annotations.
Compute external dependencies early to update StatusPoller IDs
Add ResourceReferenceFromObjMetadata
Add testutil.AssertEqual and AssertNotEqual to use without Gomega
Update solver tests to use AssertEquals, instead of custom diffs
Allow WaitTask without ApplyTask for external dependencies
Update graph.SortObjs to return external dependencies
Add Equal func to ApplyTask and WaitTask, for testing
Move Condition to its own file (same pkg)
Expose TaskName and Mapper in WaitTask for testing
Add ObjMetadataSet for testing comparisons
Add UnstructuredSet for testing comparisons
Refactor Task.Identifiers() to return ObjMetadataSet
Make YamlStringer support any interface{}
Set YamlToUnstructured as a test Helper to improve failure file:line
Add ErrorEvent support to event list e2e tests
Add e2e tests for external dependencies
Add mutator.Mutate and MutateAll helper funcs

TODO: Pull out some changes into separate PRs:

Use runCollect in e2e tests more consistently #414
Add ExpErrorEvent for better e2e test failures #418
Add ObjMetadataSet to encapsulate set functions #419
Add global destroyer timeouts #423
Add UnstructuredSet to encapsulate set functions #426
YamlStringer for interface{}
Set YamlToUnstructured as a test Helper to improve failure file:line
Add mutator.Mutate and MutateAll helper funcs

k8s-ci-robot · 2021-09-29T05:13:24Z

Hi @karlkfi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-09-29T05:13:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karlkfi
To complete the pull request process, please assign seans3 after the PR has been reviewed.
You can assign the PR to them by writing /assign @seans3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karlkfi · 2021-09-29T22:29:49Z

Extracted collector replacement: #413

karlkfi · 2021-09-29T23:03:53Z

Pulled out runCollect: #414

- Update objects early to set default namespace for SourceRef in apply-time-mutation annotations. - Compute external dependencies early to update StatusPoller IDs - Add ResourceReferenceFromObjMetadata - Add testutil.AssertEqual and AssertNotEqual to use without Gomega - Update solver tests to use AssertEquals, instead of custom diffs - Allow WaitTask without ApplyTask for external dependencies - Update graph.SortObjs to return external dependencies - Add Equal func to ApplyTask and WaitTask, for testing - Move Condition to its own file (same pkg) - Expose TaskName and Mapper in WaitTask for testing - Add ObjMetadataSet for testing comparisons - Add UnstructuredSet for testing comparisons - Make YamlStringer support any interface{} - Add ErrorEvent support to event list e2e tests - Add e2e tests for external dependencies

- Add mutator.Mutate and MutateAll helper funcs - Use UnstructuredSet and ObjMetadataSet in sovler tests for set comparisons - Refactor Task.Identifiers() to return ObjMetadataSet - Set YamlToUnstructured as a test Helper to improve failure file:line - Fix e2e tests from GroupName refactor

karlkfi · 2021-10-06T16:12:44Z

Extracted ExpErrorEvent: #418

karlkfi · 2021-10-06T22:25:44Z

Extracted ObjMetadataSet to #419

That PR blocks a UnstructuredSet refactor and usage of AssertEqual/AssertNotEqual for DeepEquals in unit tests.

k8s-ci-robot · 2021-10-07T22:50:21Z

@karlkfi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karlkfi · 2021-10-08T00:28:02Z

AssertEqual/AssertNotEqual also required for in #423

karlkfi · 2021-10-11T17:37:13Z

UnstructuredSet pulled out to #426

k8s-triage-robot · 2022-02-08T22:38:50Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-03-10T23:33:23Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

karlkfi · 2022-04-04T23:50:16Z

/remove-lifecycle rotten

Might not get back to this immediately, but it's still on my radar.

k8s-ci-robot · 2022-04-05T16:20:04Z

@karlkfi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
cli-utils-presubmit-master-stress	`8de5ebc`	link	true	`/test cli-utils-presubmit-master-stress`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2022-07-04T16:59:15Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-08-03T17:59:10Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

karlkfi · 2022-08-11T18:17:42Z

/remove-lifecycle rotten

k8s-triage-robot · 2022-11-09T18:31:34Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-12-09T19:02:23Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2023-01-08T19:48:20Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-01-08T19:48:25Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2021

k8s-ci-robot requested review from Liujingfang1 and pwittrock September 29, 2021 05:13

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

karlkfi force-pushed the karl-external-deps branch from e83a7ad to 71917d8 Compare October 6, 2021 01:12

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2021

This was referenced Nov 12, 2021

Bug: implicit namespace resolution in apply-time-mutation causes dependency sorting failure #481

Open

What is the security model of apply-time mutation feature? #483

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 4, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 11, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 9, 2022

k8s-ci-robot closed this Jan 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add support for external dependencies #412

[WIP] Add support for external dependencies #412

karlkfi commented Sep 29, 2021 •

edited

Loading

k8s-ci-robot commented Sep 29, 2021

k8s-ci-robot commented Sep 29, 2021

karlkfi commented Sep 29, 2021

karlkfi commented Sep 29, 2021

karlkfi commented Oct 6, 2021

karlkfi commented Oct 6, 2021

k8s-ci-robot commented Oct 7, 2021

karlkfi commented Oct 8, 2021

karlkfi commented Oct 11, 2021

k8s-triage-robot commented Feb 8, 2022

k8s-triage-robot commented Mar 10, 2022

karlkfi commented Apr 4, 2022

k8s-ci-robot commented Apr 5, 2022

k8s-triage-robot commented Jul 4, 2022

k8s-triage-robot commented Aug 3, 2022

karlkfi commented Aug 11, 2022

k8s-triage-robot commented Nov 9, 2022

k8s-triage-robot commented Dec 9, 2022

k8s-triage-robot commented Jan 8, 2023

k8s-ci-robot commented Jan 8, 2023

[WIP] Add support for external dependencies #412

[WIP] Add support for external dependencies #412

Conversation

karlkfi commented Sep 29, 2021 • edited Loading

k8s-ci-robot commented Sep 29, 2021

k8s-ci-robot commented Sep 29, 2021

karlkfi commented Sep 29, 2021

karlkfi commented Sep 29, 2021

karlkfi commented Oct 6, 2021

karlkfi commented Oct 6, 2021

k8s-ci-robot commented Oct 7, 2021

karlkfi commented Oct 8, 2021

karlkfi commented Oct 11, 2021

k8s-triage-robot commented Feb 8, 2022

k8s-triage-robot commented Mar 10, 2022

karlkfi commented Apr 4, 2022

k8s-ci-robot commented Apr 5, 2022

k8s-triage-robot commented Jul 4, 2022

k8s-triage-robot commented Aug 3, 2022

karlkfi commented Aug 11, 2022

k8s-triage-robot commented Nov 9, 2022

k8s-triage-robot commented Dec 9, 2022

k8s-triage-robot commented Jan 8, 2023

k8s-ci-robot commented Jan 8, 2023

karlkfi commented Sep 29, 2021 •

edited

Loading