Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #333 Fix the created hook in page is wrongly called when layout changes #334

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

Azurewarth0920
Copy link
Contributor

Fix: #333
Check the current layout and resolved the layout component can prevent unnecessary render.

@Azurewarth0920
Copy link
Contributor Author

@ktsn
Would you like to take a look at this PR?

Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for this?

@Azurewarth0920
Copy link
Contributor Author

@ktsn
Added a test here: a04a21b

Can you review it?.

Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ktsn ktsn merged commit 10dab4e into ktsn:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report] The created hook in page is wrongly called when layout changes in Vue3.
2 participants