Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report] The created hook in page is wrongly called when layout changes in Vue3. #333

Closed
Azurewarth0920 opened this issue Aug 29, 2021 · 2 comments · Fixed by #334
Closed

Bug report] The created hook in page is wrongly called when layout changes in Vue3. #333

Azurewarth0920 opened this issue Aug 29, 2021 · 2 comments · Fixed by #334

Comments

@Azurewarth0920
Copy link
Contributor

Reproduction repo: https://github.com/Azurewarth0920/created-called-before-routechange

It seems like when changing the layout in the beforeRouteUpdate hook will cause the sub-route component to rerender.
@Azurewarth0920 Azurewarth0920 mentioned this issue Aug 29, 2021
Merged
@wulucxy
Copy link

wulucxy commented Jan 4, 2022

@Azurewarth0920 same problem here，do you solve this?

@Azurewarth0920
Copy link
Contributor Author

@wulucxy
Fixed here.
I'll mention the author to take a look at this pull request: #334

@ktsn ktsn closed this as completed in #334 Jan 31, 2022
ktsn pushed a commit that referenced this issue Jan 31, 2022
@Azurewarth0920
fix: #333 Fix the created hook in page is wrongly called when layout …
10dab4e 
…changes (#334)

* Check the render is a correct render.

* Add test: Created hook in page component should not be called when layout change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wulucxy @Azurewarth0920