Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager config mounted wrongly #205

Closed
adrwong-lora opened this issue Aug 5, 2022 · 3 comments · Fixed by #289
Closed

Manager config mounted wrongly #205

adrwong-lora opened this issue Aug 5, 2022 · 3 comments · Fixed by #289
Labels
bug Something isn't working

Comments

@adrwong-lora
Copy link

adrwong-lora commented Aug 5, 2022 •
edited
Loading

To Reproduce

  1. install modelmesh in microk8s from scratch without --quickstart
  2. use kubectl exec to get in the manager pod
  3. cd /etc/model-serving
  4. the config-defaults.yaml here is a directory, which contains a real config-defaults.yaml
  5. the mount setting can be found in https://github.com/kserve/modelmesh-serving/blob/main/config/manager/manager.yaml

Expected behavior

the config-defaults.yaml should not be a directory itself
@adrwong-lora adrwong-lora added the bug Something isn't working label Aug 5, 2022
@ckadner
Copy link
Member

ckadner commented Aug 9, 2022

Interesting. I plan to take a look at this in the next couple of days.

@njhill
Copy link
Member

njhill commented Aug 9, 2022

@adrwong-lora while not very tidy, I don't think this is actually a bug since I'm pretty sure the controller process is looking for the file where it's currently mounted. There would be no harm in simplifying though to remove the intermediate config-defaults.yaml directory.

Did you actually run into any problems functionally or this was just something you noticed that looked odd?

@adrwong-lora
Copy link
Author

It works fine, just a bit confused when I tried to look for the config-defaults.yaml it's actually reading in the pods.

ckadner added a commit to ckadner/modelmesh-serving that referenced this issue Dec 10, 2022
@ckadner
fix: config-defaults mount path
cf0d3a8 
Fixes kserve#205

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner mentioned this issue Dec 10, 2022
Merged
kserve-oss-bot pushed a commit that referenced this issue Dec 14, 2022
@ckadner
fix: config-defaults mount path (#289)
b35ea42 
#### Motivation

The file containing the default configuration for the ModelMesh Controller is called `config-defaults.yaml`, which resides in a directory also called `config-defaults.yaml` as pointed out by @adrwong-lora in issue #205
```
/etc/model-serving/config-defaults.yaml/config-defaults.yaml
```

#### Modifications

Change `mountPath` from `/etc/model-serving/config-defaults.yaml` to `/etc/model-serving/config/default`

#### Result

The file containing the default configuration file after this fix:

```
/etc/model-serving/config/default/config-defaults.yaml
```

Which more closely reflects the path of the [`config-defaults.yaml`](https://github.com/kserve/modelmesh-serving/blob/main/config/default/config-defaults.yaml) file in the `modelmesh-serving` repository:
```
config/default/config-defaults.yaml
```

Resolves #205 

/cc @njhill 
/fyi @adrwong-lora

Signed-off-by: Christian Kadner <[email protected]>
hdefazio pushed a commit to hdefazio/modelmesh-serving that referenced this issue Jan 16, 2025
@openshift-merge-robot
Merge pull request kserve#205 from Jooho/20230915_update_0.11
beff10d 
formatting README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: config-defaults mount path ckadner/modelmesh-serving
3 participants
@ckadner @njhill @adrwong-lora