Skip to content

Commit

Permalink
fix: config-defaults mount path (#289)
Browse files Browse the repository at this point in the history
#### Motivation

The file containing the default configuration for the ModelMesh Controller is called `config-defaults.yaml`, which resides in a directory also called `config-defaults.yaml` as pointed out by @adrwong-lora in issue #205
```
/etc/model-serving/config-defaults.yaml/config-defaults.yaml
```

#### Modifications

Change `mountPath` from `/etc/model-serving/config-defaults.yaml` to `/etc/model-serving/config/default`

#### Result

The file containing the default configuration file after this fix:

```
/etc/model-serving/config/default/config-defaults.yaml
```

Which more closely reflects the path of the [`config-defaults.yaml`](https://github.com/kserve/modelmesh-serving/blob/main/config/default/config-defaults.yaml) file in the `modelmesh-serving` repository:
```
config/default/config-defaults.yaml
```

Resolves #205 

/cc @njhill 
/fyi @adrwong-lora

Signed-off-by: Christian Kadner <[email protected]>
  • Loading branch information
ckadner authored Dec 14, 2022
1 parent 0af760d commit b35ea42
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ spec:
cpu: "1"
memory: 512Mi
volumeMounts:
- mountPath: /etc/model-serving/config-defaults.yaml
- mountPath: /etc/model-serving/config/default
name: config-defaults
readOnly: true
securityContext:
Expand Down
4 changes: 2 additions & 2 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -43,7 +43,7 @@ const (
DefaultEtcdSecretName = "model-serving-etcd"

ConfigType = "yaml"
MountLocation = "/etc/model-serving/config-defaults.yaml"
MountLocation = "/etc/model-serving/config/default"
ViperKeyDelimiter = "::"
)

Expand Down

0 comments on commit b35ea42

Please sign in to comment.