Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump API doesn't work in JS and WasmJS #279

Closed
krzema12 opened this issue Dec 14, 2024 · 0 comments
Closed

Dump API doesn't work in JS and WasmJS #279

krzema12 opened this issue Dec 14, 2024 · 0 comments
Assignees
@OptimumCode
Labels
bug Something isn't working

Comments

@krzema12
Copy link
Owner

krzema12 commented Dec 14, 2024 •
edited
Loading

identityHashCode for JS and WasmJS are broken. See #273

In short, implementations of this function for JS and WasmJS don't work the same way as for e.g. the JVM because there can be primitive types that cannot be extended in runtime, and no auto-boxing is implemented there.

This issue likely doesn't affect kaml which uses lower-level API.
@krzema12 krzema12 added the bug Something isn't working label Dec 14, 2024
This was referenced Dec 14, 2024
Merged
Merged
krzema12 pushed a commit that referenced this issue Dec 16, 2024
@OptimumCode
test: migrate tests for representer package to common sources (#278)
9e9ea24 
This PR migrates tests for the `representer` package to common sources.
This should provide some coverage for `identityHashCode` function that
does not work correctly on all platforms.

Part of #269 and
#279.
krzema12 added a commit that referenced this issue Dec 28, 2024
@krzema12 @OptimumCode
Fix identityHashCode for JS and WasmJS (#273)
60a4593 
Part of #279

---------

Co-authored-by: Oleg Smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OptimumCode OptimumCode

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krzema12 @OptimumCode