Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port tests to common Kotlin #269

Open
krzema12 opened this issue Nov 11, 2024 · 2 comments
Open

Port tests to common Kotlin #269

krzema12 opened this issue Nov 11, 2024 · 2 comments
Assignees
@krzema12

Comments

@krzema12
Copy link
Owner

krzema12 commented Nov 11, 2024 •
edited
Loading

To be able to run the tests for all supported platforms, let's first convert them from Java to Kotlin.

Focusing on tests that use some files from the resources, starting from the tests that have most LoC:

Harder ones:

Tests not relying on test resources:

  • 228 ./org/snakeyaml/engine/v2/comments/ProblematicYamlTest.java
  • 188 ./org/snakeyaml/engine/v2/api/LoadTest.java
  • 179 ./org/snakeyaml/engine/v2/api/dump/DumpSettingsTest.java
  • 129 ./org/snakeyaml/engine/schema/NumberCoreTest.java
  • 128 ./org/snakeyaml/engine/usecases/env/EnvFormatTest.java
  • 126 ./org/snakeyaml/engine/v2/api/DumpTest.java
  • 125 ./org/snakeyaml/engine/usecases/tags/TimestampTagTest.java
  • 120 ./org/snakeyaml/engine/v2/api/LoadSettingsTest.java
  • 118 ./org/snakeyaml/engine/v2/emitter/AnchorUnicodeTest.java
  • 114 ./org/snakeyaml/engine/v2/api/types/OptionalTest.java
  • 113 ./org/snakeyaml/engine/schema/NumberJsonTest.java
  • 112 ./org/snakeyaml/engine/usecases/untrusted/DocumentSizeLimitTest.java
  • 112 ./org/snakeyaml/engine/usecases/external_test_suite/SuiteUtils.java - Remove Java-based YAML test suite #370
  • 109 ./org/snakeyaml/engine/usecases/external_test_suite/EventRepresentation.java - Remove Java-based YAML test suite #370
  • 108 ./org/snakeyaml/engine/v2/exceptions/MarkTest.java
  • 108 ./org/snakeyaml/engine/issues/issue46/JRubyPsychTest.java
  • 105 ./org/snakeyaml/engine/usecases/binary/BinaryRoundTripTest.java
  • 90 ./org/snakeyaml/engine/usecases/references/BillionLaughsAttackTest.java
  • 89 ./org/snakeyaml/engine/usecases/recursive/RecursiveMapTest.java
  • 83 ./org/snakeyaml/engine/v2/emitter/FlexSimleKeyTest.java
  • 83 ./org/snakeyaml/engine/issues/issue544/DoubleQuoteTest.java
  • 80 ./org/snakeyaml/engine/v2/common/CharConstantsTest.java
  • 77 ./org/snakeyaml/engine/usecases/references/NonAsciiAnchorTest.java
  • 75 ./org/snakeyaml/engine/issues/issue17/WindowsTest.java
  • 74 ./org/snakeyaml/engine/issues/issue23/EmptyStringOutputTest.java
  • 72 ./org/snakeyaml/engine/v2/scanner/FuzzYAMLRead50431Test.java
  • 72 ./org/snakeyaml/engine/v2/api/ConstructNodeTest.java
  • 71 ./org/snakeyaml/engine/issues/issue36/EmitCommentTest.java
  • 70 ./org/snakeyaml/engine/v2/common/SpecVersionTest.java
  • 69 ./org/snakeyaml/engine/v2/common/AnchorTest.java
  • 68 ./org/snakeyaml/engine/v2/api/types/UuidTest.java
  • 64 ./org/snakeyaml/engine/v2/constructor/DefaultConstructorTest.java
  • 64 ./org/snakeyaml/engine/usecases/untrusted/ByteLimitTest.java
  • 64 ./org/snakeyaml/engine/issues/issue1/NullConstructorTest.java
  • 61 ./org/snakeyaml/engine/usecases/custom_collections/CustomDefaultCollectionsTest.java
  • 59 ./org/snakeyaml/engine/v2/parser/ParserTest.java
  • 59 ./org/snakeyaml/engine/v2/api/lowlevel/ComposeTest.java
  • 58 ./org/snakeyaml/engine/schema/BooleanCoreTest.java
  • 57 ./org/snakeyaml/engine/usecases/external_test_suite/SuiteData.java - Remove Java-based YAML test suite #370
  • 56 ./org/snakeyaml/engine/usecases/fuzzy/FuzzYAMLRead56902Test.java
  • 55 ./org/snakeyaml/engine/issues/issue25/DumpToStringTest.java
  • 53 ./org/snakeyaml/engine/v2/utils/TestUtils.java
  • 53 ./org/snakeyaml/engine/v2/composer/ComposerTest.java
  • 53 ./org/snakeyaml/engine/v2/api/lowlevel/ParseTest.java
  • 53 ./org/snakeyaml/engine/usecases/external_test_suite/EmitSuiteTest.java - Remove Java-based YAML test suite #370
  • 52 ./org/snakeyaml/engine/issues/issue11/TabInFlowContextTest.java
  • 51 ./org/snakeyaml/engine/v2/nodes/MappingNodeTest.java
  • 50 ./org/snakeyaml/engine/v2/nodes/NodeTest.java
  • 50 ./org/snakeyaml/engine/v2/api/lowlevel/SerializeTest.java
  • 50 ./org/snakeyaml/engine/schema/FailsafeTest.java
  • 47 ./org/snakeyaml/engine/issues/issue51/LoadSettingsBufferSizeTest.java
  • 46 ./org/snakeyaml/engine/usecases/colon_in_flow_context/ColonInFlowContextInMapTest.java
  • 46 ./org/snakeyaml/engine/usecases/colon_in_flow_context/ColonInFlowContextInListTest.java
  • 46 ./org/snakeyaml/engine/schema/NullCoreTest.java
  • 46 ./org/snakeyaml/engine/issues/issue3/ExceptionTest.java
  • 45 ./org/snakeyaml/engine/v2/events/EventTest.java
  • 45 ./org/snakeyaml/engine/usecases/fuzzy/FuzzyCollectionTest.java
  • 44 ./org/snakeyaml/engine/v2/emitter/UseUnicodeEncodingTest.java
  • 44 ./org/snakeyaml/engine/schema/BooleanJsonTest.java
  • 43 ./org/snakeyaml/engine/v2/common/UriEncoderTest.java
  • 43 ./org/snakeyaml/engine/usecases/tags/SetsTagTest.java
  • 43 ./org/snakeyaml/engine/usecases/tags/LocalTagTest.java
  • 42 ./org/snakeyaml/engine/usecases/tags/ExplicitRootTagTest.java
  • 40 ./org/snakeyaml/engine/schema/NullJsonTest.java
  • 39 ./org/snakeyaml/engine/issues/issue44/ProtectedClassesTest.java
  • 37 ./org/snakeyaml/engine/v2/resolver/CoreScalarResolverTest.java - Kotlinize and commonize CoreScalarResolverTest #397
  • 36 ./org/snakeyaml/engine/usecases/references/RestrictAliasNamesTest.java
  • 35 ./org/snakeyaml/engine/usecases/env/SetEnvVariableTest.java
  • 35 ./org/snakeyaml/engine/usecases/env/EnvTagTest.java
  • 35 ./org/snakeyaml/engine/issues/issue17/WindowsLinesTest.java
  • 35 ./org/snakeyaml/engine/internal/SystemPropertyExtension.java
  • 33 ./org/snakeyaml/engine/v2/resolver/ScalarResolverTupleTest.java
  • 32 ./org/snakeyaml/engine/v2/scanner/SimpleKeyTest.java
  • 31 ./org/snakeyaml/engine/v2/parser/VersionTagsTupleTest.java
  • 31 ./org/snakeyaml/engine/usecases/tags/CustomConstructor.java
  • 30 ./org/snakeyaml/engine/v2/tokens/TokenTest.java
  • 30 ./org/snakeyaml/engine/usecases/tags/ImportValueImpl.java
  • 30 ./org/snakeyaml/engine/internal/SystemProperty.java
  • 29 ./org/snakeyaml/engine/v2/events/ImplicitTupleTest.java
  • 17 ./org/snakeyaml/engine/internal/TestConstructNode.java
@krzema12 krzema12 mentioned this issue Nov 11, 2024
Merged
krzema12 added a commit that referenced this issue Nov 12, 2024
@krzema12
Convert EmitterWithCommentEnabledTest to Kotlin (#268)
6c52b61 
Part of #269.

The first commit is the output from Java-to-Kotlin converter, along with
necessary fixes to make the tests pass.
The second commit cleans the file up a bit and brings Kotlin-specific
style.
These can be squashed upon merging.
@krzema12
Copy link
Owner Author

This task is becoming more important as we need to add platform-specific logic, and ensure things still work. See e. g. #272.

@krzema12 krzema12 mentioned this issue Dec 14, 2024
Merged
krzema12 pushed a commit that referenced this issue Dec 16, 2024
@OptimumCode
test: migrate tests for representer package to common sources (#278)
9e9ea24 
This PR migrates tests for the `representer` package to common sources.
This should provide some coverage for `identityHashCode` function that
does not work correctly on all platforms.

Part of #269 and
#279.
krzema12 added a commit that referenced this issue Jan 3, 2025
@krzema12
Commonize DumpAnchorTest
674bfb7 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 3, 2025
Merged
krzema12 added a commit that referenced this issue Jan 3, 2025
@krzema12
Commonize DumpAnchorTest (#326)
65b72bd 
Part of #269.
krzema12 added a commit that referenced this issue Jan 3, 2025
@krzema12
Commonize EmitterWithCommentEnabledTest
eba55ed 
Part of #269
@krzema12 krzema12 mentioned this issue Jan 3, 2025
Merged
krzema12 added a commit that referenced this issue Jan 3, 2025
@krzema12
Commonize EmitterWithCommentEnabledTest (#329)
fde54d5 
Part of #269
@krzema12 krzema12 mentioned this issue Jan 4, 2025
Merged
krzema12 added a commit that referenced this issue Jan 4, 2025
@krzema12
Commonize YamlUnicodeReaderTest (#330)
c7feaba 
Part of #269.
@krzema12 krzema12 self-assigned this Jan 4, 2025
This was referenced Jan 4, 2025
Merged
Merged
Merged
krzema12 added a commit that referenced this issue Jan 8, 2025
@krzema12
Kotlinize and commonize IndentWithIndicatorTest (#338)
0d26c60 
Part of #269.
krzema12 added a commit that referenced this issue Jan 8, 2025
@krzema12
Kotlinize and partially commonize EnvVariableTest (#332)
b158d57 
Part of #269
krzema12 added a commit that referenced this issue Jan 8, 2025
@krzema12
Kotlinize and commonize EmitCommentAndSpacesTest (#339)
c69febd 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 9, 2025
Merged
krzema12 added a commit that referenced this issue Jan 9, 2025
@krzema12
Kotlinize and commonize LoadSequenceTest (#346)
459e416 
Part of #269.
This was referenced Jan 9, 2025
Merged
Merged
krzema12 added a commit that referenced this issue Jan 9, 2025
@krzema12
Kotlinize and commonize GlobalDirectivesTest (#347)
7ba7421 
Part of #269
krzema12 added a commit that referenced this issue Jan 9, 2025
@krzema12
Kotlinize and commonize LoadMappingTest (#348)
9d4db94 
Part of #269
@krzema12 krzema12 mentioned this issue Jan 10, 2025
Merged
krzema12 added a commit that referenced this issue Jan 10, 2025
@krzema12 @OptimumCode
Kotlinize and commonize RecursiveSetTest (#351)
aef07c9 
Part of #269

---------

Co-authored-by: Oleg Smirnov <[email protected]>
This was referenced Jan 10, 2025
Merged
Merged
@krzema12 krzema12 changed the title Port tests to Kotlin Port tests to common Kotlin Jan 15, 2025
@mervyn-mccreight
Copy link

I'll happily support here when I find the time to do so :)

krzema12 added a commit that referenced this issue Jan 15, 2025
@krzema12
Kotlinize inherited tests (#358)
75eba86 
Part of #269.

Focuses just on porting a group of related tests (with a common parent
class) to Kotlin, for now JVM-specific. Commonization will be done in a
separate change.
@krzema12 krzema12 mentioned this issue Jan 16, 2025
Merged
krzema12 added a commit that referenced this issue Jan 16, 2025
@krzema12
Use Okio in inherited tests (#360)
825efa0 
Part of #269.

I'm planning to implement Okio's file system to reflect the common test
resources, so this refactoring brings us closer to this idea.
@krzema12 krzema12 mentioned this issue Jan 16, 2025
Merged
krzema12 added a commit that referenced this issue Jan 16, 2025
@krzema12
Move inherited YAML resources to common resources (#356)
8008b49 
Part of #269.

This change focuses solely on moving the resource files, and any
adjustments that have to happen for it to work. It's a step towards
commonization of the inherited tests.
@krzema12 krzema12 mentioned this issue Jan 17, 2025
Merged
krzema12 added a commit that referenced this issue Jan 17, 2025
@krzema12
Implement file system based on common test resources and use it in st…
30d5f70 
…ringFromResources (#365)

Part of #269.

It's a step towards using other common test resources. It focuses on
implementing the custom Okio file system, and while we're doing it, we
can reuse it for retrieving a single common test resource to avoid
duplication.
This was referenced Jan 17, 2025
Merged
Merged
krzema12 added a commit that referenced this issue Jan 17, 2025
@krzema12
Commonize inherited tests (#363)
e4c87fa 
Part of #269.

It was necessary to adjust the code a bit since some functions were
still JVM-specific.
krzema12 added a commit that referenced this issue Jan 17, 2025
@krzema12
Remove JVM-specific way of reading test resources (#366)
dabbc26 
Part of #269.

It's not used anywhere, after migrating tests that use resources to
common Kotlin.
@krzema12 krzema12 mentioned this issue Jan 18, 2025
Merged
krzema12 added a commit that referenced this issue Jan 19, 2025
@krzema12
Kotlinize and commonize OptionalMarksTest (#371)
3d0c7b1 
Part of #269.
krzema12 added a commit that referenced this issue Jan 20, 2025
@krzema12
Kotlinize and commonize ComposerWithCommentEnabledTest
5ab2fa6 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 20, 2025
Merged
krzema12 added a commit that referenced this issue Jan 20, 2025
@krzema12
Kotlinize and commonize ComposerWithCommentEnabledTest (#374)
d8f3b82 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 23, 2025
Merged
krzema12 added a commit that referenced this issue Jan 23, 2025
@krzema12
Kotlinize and commonize SerializerWithCommentEnabledTest (#379)
1ca7d17 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 24, 2025
Merged
krzema12 added a commit that referenced this issue Jan 24, 2025
@krzema12
Kotlinize and commonize ParserWithCommentEnabledTest (#381)
1a6a395 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 25, 2025
Merged
krzema12 added a commit that referenced this issue Jan 27, 2025
@krzema12
Kotlinize and commonize EmitterTest (#383)
b6a9a8f 
Part of #269.
@krzema12 krzema12 mentioned this issue Jan 28, 2025
Merged
krzema12 added a commit that referenced this issue Jan 28, 2025
@krzema12
Kotlinize and commonize ScannerWithCommentEnabledTest (#387)
cc71a2c 
Part of #269.
This was referenced Feb 4, 2025
Merged
Merged
krzema12 added a commit that referenced this issue Feb 5, 2025
@krzema12
Kotlinize and commonize JsonScalarResolverTest (#399)
15d752d 
Part of #269.
krzema12 added a commit that referenced this issue Feb 6, 2025
@krzema12
Kotlinize and commonize CoreScalarResolverTest (#397)
5fd5278 
Part of #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzema12 krzema12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krzema12 @mervyn-mccreight