Make getContentOriginOffset to know info about if call-site want tran…

…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
kosmydel · Jun 12, 2024 · 9561971 · 9561971
1 parent 42f136d
commit 9561971
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp
@@ -194,6 +194,7 @@ Transform LayoutableShadowNode::getTransform() const {
 
 Point LayoutableShadowNode::getContentOriginOffset(
     bool /*includeTransform*/) const {
+
   return {0, 0};
 }
 

diff --git a/packages/react-native/ReactCommon/react/renderer/core/tests/TestComponent.h b/packages/react-native/ReactCommon/react/renderer/core/tests/TestComponent.h
@@ -77,7 +77,8 @@ class TestShadowNode final : public ConcreteViewShadowNode<
   facebook::react::Point _contentOriginOffset{};
 
   facebook::react::Point getContentOriginOffset(
-      bool /*includeTransform*/) const override {
+      bool /* includeTransform */) const override {
+
     return _contentOriginOffset;
   }
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -194,6 +194,7 @@ Transform LayoutableShadowNode::getTransform() const { @@
     Point LayoutableShadowNode::getContentOriginOffset(
         bool /*includeTransform*/) const {
       return {0, 0};
     }
@@ Expand Down @@