Make getContentOriginOffset to know info about if call-site want transform or not #44822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
Base commit: c9d7774 |
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 6, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
6d61761 to
bb1f50f
Compare
|
This is a pre-req for this bugfix #44168 |
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 7, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
bb1f50f to
cd5dea1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
force-pushed
the
export-D58223380
branch
from
cd5dea1 to
87fc8d4
Compare
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 7, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
force-pushed
the
export-D58223380
branch
from
87fc8d4 to
0bbf3dc
Compare
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
0bbf3dc to
7dc9c9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
7dc9c9c to
2f4221a
Compare
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
2f4221a to
549a3f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
added a commit
to realsoelynn/react-native
that referenced
this pull request
Jun 11, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
realsoelynn
force-pushed
the
export-D58223380
branch
from
549a3f3 to
291b0c9
Compare
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Breaking] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Reviewed By: NickGerleman Differential Revision: D58223380
|
This pull request was exported from Phabricator. Differential Revision: D58223380 |
realsoelynn
force-pushed
the
export-D58223380
branch
from
291b0c9 to
f8bf87f
Compare
|
This pull request has been merged in ce588db. |
|
This pull request was successfully merged by @realsoelynn in ce588db. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 12, 2024
…sform or not (facebook#44822) Summary: Pull Request resolved: facebook#44822 Changelog: [Internal] This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation. Differential Revision: D58223380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is to make
getContentOriginOffsetto haveincludeTransforminformation passed during Layout computation.Differential Revision: D58223380