Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make translate_span a little faster #132

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Make translate_span a little faster #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
054f72e
Make translate_span a little faster
torarvid Jun 2, 2023
cbac048
isort
torarvid Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions troncos/tracing/_span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
from opentelemetry.trace import SpanContext, SpanKind, Status, StatusCode
from opentelemetry.trace.span import TraceFlags

_dd_span_ignore_attr = [
_dd_span_ignore_attr = {
"runtime-id",
"_sampling_priority_v1",
"env",
"version",
"span.kind",
]
}


def _span_context(span: DDSpan) -> SpanContext:
Expand Down Expand Up @@ -58,7 +58,7 @@ def _span_kind(dd_span: DDSpan) -> SpanKind:


def _span_status_and_attributes(
dd_span: DDSpan, ignore_attrs: list[str]
dd_span: DDSpan, ignore_attrs: set[str]
) -> tuple[Status, list[Event], dict[str, Any]]:
dd_span_err_attr_mapping = {
"error.msg": "exception.message",
Expand Down Expand Up @@ -124,13 +124,18 @@ def _span_resource(dd_span: DDSpan, default_resource: Resource) -> Resource:
return Resource(base_attributes)


def translate_span(dd_span: DDSpan, default_resource: Resource) -> ReadableSpan:
def default_ignore_attrs() -> set[str]:
return _dd_span_ignore_attr


def translate_span(
dd_span: DDSpan, default_resource: Resource, ignore_attrs: set[str]
) -> ReadableSpan:
"""Transelate a ddtrace span to an OTEL span."""
assert dd_span.duration_ns, "Span not finished."

status, events, attributes = _span_status_and_attributes(
dd_span,
ignore_attrs=_dd_span_ignore_attr + list(default_resource.attributes.keys()),
dd_span, ignore_attrs=ignore_attrs
)

otel_span = ReadableSpan(
Expand Down
11 changes: 9 additions & 2 deletions troncos/tracing/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from ._enums import Exporter
from ._otel import get_otel_span_processors
from ._span import translate_span
from ._span import default_ignore_attrs, translate_span


class OTELWriter(TraceWriter):
Expand All @@ -28,6 +28,9 @@ def __init__(
self.otel_default_resource = Resource.create(
{"service.name": service_name, **(service_attributes or {})}
)
self.otel_ignore_attrs = (
set(self.otel_default_resource.attributes.keys()) | default_ignore_attrs()
)

def recreate(self) -> "OTELWriter":
return self.__class__(
Expand All @@ -39,7 +42,11 @@ def recreate(self) -> "OTELWriter":

def write(self, spans: list[Span] | None = None) -> None:
transelated_spans = [
translate_span(span, default_resource=self.otel_default_resource)
translate_span(
span,
default_resource=self.otel_default_resource,
ignore_attrs=self.otel_ignore_attrs,
)
for span in spans or []
]

Expand Down