Make translate_span a little faster #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using py-spy, it looks like the previous version spent some time doing list(default_resource.attributes.keys()) every time it was called. It seems this can be done once in the OTELWriter constructor instead. Also, I think we can make it a set instead of a list (I believe `a in my_set` is a bit quicker than `a in my_list`). Does this commit include tests to verify the speed increase? Nah... 🤷
eirsyl
added a commit
that referenced
this pull request
Jun 13, 2023
* Initial v4 version * Django logging middleware (#124) * Initial django logging middleware * Add django middleware docs * Bump version * Celery task log (#125) * Initial celery signals * Add celery task logging * Add docs (#126) * Bump version * Add GRPC span exporter (#127) * Bump version * Use BoundedAttributes when adding attributes to events * Bump version * Change span class * Bump version * Use ReadonlySpan, Span uses locks * Bump version * Dont use Resource.create, it tries to detect app info we dont need * Bump version * Add structlog logfmt renderer * Add print_loggers helper tool * Add decorators * Remove required logger prefix in middleware * Explicitly log trace_id in ASGI middleware * Dont log empty events * Make django profiling view sync * Bump version * Make translate_span a little faster (#132) * Make translate_span a little faster Using py-spy, it looks like the previous version spent some time doing list(default_resource.attributes.keys()) every time it was called. It seems this can be done once in the OTELWriter constructor instead. Also, I think we can make it a set instead of a list (I believe `a in my_set` is a bit quicker than `a in my_list`). Does this commit include tests to verify the speed increase? Nah... 🤷 * isort * Bump version * Add some tiny performance improvements * Drop sampled spans (#135) * Dont write sampled spans to the otel endpoint * Add span.sampled check * Bump version * Add py-spy profiler support (#137) * Bump version * Add basic and token auth support to py-spy profiler (#138) * Bump version * Add instance tag to the py-spy profiler * Use tracer tags, this lets us reuse tags added by tracer.set_tags --------- Co-authored-by: Guðmundur Björn Birkisson <[email protected]> Co-authored-by: Tor Arvid Lund <[email protected]> Co-authored-by: Tor Arvid Lund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using py-spy, it looks like the previous version spent some time doing
list(default_resource.attributes.keys()) every time it was called.
It seems this can be done once in the OTELWriter constructor instead. Also, I think we can make it a set instead of a list (I believe
a in my_setis a bit quicker thana in my_list).Does this commit include tests to verify the speed increase? Nah... 🤷