Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/utils has redundancies with knative/pkg #2884

Closed
mattmoor opened this issue Mar 31, 2020 · 6 comments · Fixed by #4160, knative/eventing-contrib#1620, knative-extensions/eventing-natss#21 or knative-extensions/eventing-couchdb#7
Closed

pkg/utils has redundancies with knative/pkg #2884

mattmoor opened this issue Mar 31, 2020 · 6 comments · Fixed by #4160, knative/eventing-contrib#1620, knative-extensions/eventing-natss#21 or knative-extensions/eventing-couchdb#7
Assignees
@runzexia
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Backlog

Comments

@mattmoor
Copy link
Member

In particular the handling of cluster domains is redundant with: https://github.com/knative/pkg/blob/master/network/domain.go

/kind good-first-issue
@mattmoor mattmoor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 31, 2020
@knative-prow-robot knative-prow-robot added the kind/good-first-issue Denotes an issue ready for a new contributor. label Mar 31, 2020
@odacremolbap
Copy link
Contributor

Can I get assigned here please?

@lionelvillard
Copy link
Member

/assign

@grantr grantr assigned odacremolbap and unassigned lionelvillard Apr 6, 2020
@grantr grantr added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 6, 2020
@grantr grantr added this to the Backlog milestone Aug 24, 2020
@runzexia
Copy link
Contributor

Is there anyone still dealing with this problem? If not, I could help.

@lionelvillard
Copy link
Member

/unassign @odacremolbap
/assign @runzexia

Thanks @runzexia for taking a look at this one!

This was referenced Sep 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@runzexia
Copy link
Contributor

/reopen

@knative-prow-robot
Copy link
Contributor

@runzexia: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runzexia runzexia mentioned this issue Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runzexia runzexia

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Backlog
6 participants
@grantr @mattmoor @lionelvillard @odacremolbap @runzexia @knative-prow-robot