Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use utils in knative/pkg #98

Merged
merged 3 commits into from
Sep 30, 2020
Merged

use utils in knative/pkg #98

merged 3 commits into from
Sep 30, 2020

Conversation

runzexia
Copy link
Contributor

Signed-off-by: runzexia [email protected]
knative/eventing#2884

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 30, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 30, 2020
@knative-prow-robot
Copy link

Welcome @runzexia! It looks like this is your first PR to knative-sandbox/eventing-rabbitmq 🎉

@runzexia
fix ut
2b5043d 
Signed-off-by: runzexia <[email protected]>
@codecov
Copy link

codecov bot commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files          22       22           
  Lines        1084     1084           
=======================================
  Hits          818      818           
  Misses        209      209           
  Partials       57       57
Impacted Files Coverage Δ
pkg/reconciler/source/resources/receive_adapter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c632545...11fb273. Read the comment docs.

@runzexia runzexia changed the title clean up redundancies code with knative/pkg use utils in knative/pkg Sep 30, 2020
@runzexia
generate name
11fb273 
Signed-off-by: runzexia <[email protected]>
@vaikas
Copy link
Contributor

vaikas commented Sep 30, 2020

/lgtm
/approve
Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runzexia, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@knative-prow-robot knative-prow-robot merged commit a01f516 into knative-extensions:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runzexia @knative-prow-robot @vaikas @googlebot