-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Ember 3.7? #83
Comments
Yes, getting this too, from document-title.js line 75 |
Seems that from Ember 3.7.0 |
Actually, it's this issue #16312, included in Ember 3.1.0. From Ember 3.7.0, the deprecated self.router has been removed. |
@mike-north made a fork https://github.com/mike-north/ember-cli-document-title-northm and I am currently using it in a project (eliminates the console warnings). I recommend creating an issue or pull request there. |
Resolution for running into kimroen/ember-cli-document-title#83 in Fastboot environment
Is this issue still present? I'm getting it after just installing it now. self.router.setTitle(finalTitle); is crashing out. |
https://github.com/kimroen/ember-cli-document-title/blob/master/vendor/document-title/document-title.js#L73-L76 |
1.0 released! |
Seems that the recent changes around the router service in Ember 3.7 breaks the add-on.
After upgrading I started to get this error:
After digging through my node modules for
setTitle
, the only hit was this add-on.The text was updated successfully, but these errors were encountered: