feat(windows): background updates go from downloading to waiting for a restart except if the apply now
flag is set
#13159
+7
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only go to the installing state if
apply now
has been set. Otherwise go to WaitingRestart. This can be Revistied in Stage 2 #8993Fixes: #13155
User Testing
TEST_IDLE_KMSHELL_UPDATEDS_KBDS_ONLY
To Test this PR we need it so there are no newer updates available. If there are let me know and
I will merge in the lastest master again.
update state
found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine).usIdle
cd "c:\Program Files (x86)\Keyman\Keyman Desktop"
kmshell.exe -buc
update state
has advanced tousUpdateAvailable
thenusDownloading
and finallyusWaitngRestart
. Press F5 to refresh the view.TEST_IDLE_KMSHELL_UPDATEDS_KBDS_ONLY_APPLY_NOW
To Test this PR we need it so there are no newer updates available. If there are let me know and
I will merge in the lastest master again.
update state
found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine).usIdle
Apply Now
button.update
buttonallow
update state
in the regedit window is backusIdle