Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): condition to go from downloading to waitingrestart changed for keyman update state machine #13155

Closed
rc-swag opened this issue Feb 7, 2025 · 0 comments · Fixed by #13159
Assignees
Milestone

Comments

@rc-swag
Copy link
Contributor

rc-swag commented Feb 7, 2025

Background:
Because elevated permissions are needed there was pop-up to let the user know that install was about to start so that the elevated permission question was not seen as suspicious. This was in the state machine module. The UI pop-up was decoupled and placed into the main start-up code of all of kmshell. This is working well for most scenarios there is still cases where the state machine will just advance through all states and start installing and the user first nows about it via kmshell permissions popup. The proposal for now is to always have go from downloading to waitingrestart state unless the apply now flag is set.

Example
Keyman has not run. Keyman Configuration is opened, background update kicks off and finds a download, downloads it checks if keyman as run, it hasn't so it starts the install without notifying the user. With the proposed solution it would go to WaitingRestart. So the next time kmshell is run for configuration, keyman etc the install pop-up can request permssion from the user.
In stage 2 we can improve this.

@rc-swag rc-swag self-assigned this Feb 7, 2025
@rc-swag rc-swag moved this to Todo in Keyman Feb 7, 2025
@rc-swag rc-swag changed the title feat(windows): Always go from downloading to waitingrestart online updates feat(windows): Always go from downloading to waitingrestart - online updates Feb 7, 2025
@rc-swag rc-swag changed the title feat(windows): Always go from downloading to waitingrestart - online updates feat(windows): condition to go from downloading to waitingrestart changed for keyman update state machine \ Feb 7, 2025
@rc-swag rc-swag added this to the B18S1 milestone Feb 7, 2025
@rc-swag rc-swag changed the title feat(windows): condition to go from downloading to waitingrestart changed for keyman update state machine \ feat(windows): condition to go from downloading to waitingrestart changed for keyman update state machine Feb 7, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
1 participant