Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(models/templates): seed epic/model-encoding with cherry-pick from epic/user-dict 💾 #12268

Merged
merged 11 commits into from
Aug 27, 2024
Merged

chore(models/templates): seed epic/model-encoding with cherry-pick from epic/user-dict 💾 #12268

merged 11 commits into from
Aug 27, 2024

Conversation

jahorton
Copy link
Contributor

This PR extracts the changes currently within the epic/user-dict feature branch that are also needed for enhanced model encoding to serve as the base of epic/model-encoding. All were changes were previously reviewed for epic/user-dict:

Other PRs have since been merged there, but are irrelevant for the purposes of the epic/model-encoding feature.

@keymanapp-test-bot skip

jahorton and others added 11 commits August 23, 2024 11:39
@jahorton
refactor(common/models): split trie-model implementation into separat…
2db1d4e 
…e components
@jahorton
refactor(developer/compilers): prepare for trie-compiler split
c7c534a
@jahorton
refactor(common/models): move primary trie-compilation code into comm…
c21b864 
…on/models/templates

We'll likely want to dynamically build a Trie to represent user-specific entries made available by the active OS.  We'll then blend _that_ with the 'static' distributed model.
@jahorton
fix(developer): add 'build' dependency link to models/templates
2db0302
@mcdurdin @jahorton
chore: establish user-dict epic
8789d72
@jahorton @mcdurdin
chore(common/models): Apply suggestions from code review
3cea701 
Co-authored-by: Marc Durdin <[email protected]>
@jahorton
fix(developer): sets models-templates as package.json dependency
b884e15
@jahorton
chore(common): update package-lock.json
b53c325
@jahorton
refactor(common/models): refactor migrated trie-construction code for…
d286b3f 
… improved encapsulation
@jahorton
change(common/models): clean up trie construction code, add unit tests
57146e1
@jahorton
fix(common/models): relocates sortNode to avoid cyclic imports
a8a665f
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 23, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S9 milestone Aug 23, 2024
mcdurdin
mcdurdin approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jahorton jahorton merged commit 745172c into epic/model-encoding Aug 27, 2024
17 of 18 checks passed
@jahorton jahorton deleted the chore/models/seed-epic-model-encoding branch August 27, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees
No one assigned
Labels
chore common/models/templates/ common/models/ common/ developer/compilers/ developer/ epic-model-encoding web/
Projects
Keyman
Archived in project
Milestone
A18S9
Development

Successfully merging this pull request may close these issues.
2 participants
@jahorton @mcdurdin