refactor(common/models): split trie-model implementation into separate components 📖 #12080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
common/
common/models/
common/models/templates/
refactor
labels
jahorton
force-pushed
the
refactor/common/models/trie-model
branch
from
1689a1e to
7644d38
Compare
|
Had a bit of a scare when testing followups locally - this scare resulted in #12082. |
mcdurdin
approved these changes
Aug 5, 2024
Co-authored-by: Marc Durdin <[email protected]>
…mon/models/trie-model
…ommon/models/trie-model' into refactor/common/models/trie-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work intended to help implement #10973.
We'll obviously need to model the user-specific lexicon in some manner, and as it turns out... mobile-device OSes pretty much hand us a wordlist for the data we're looking to integrate first in that regard. Thing is, to make a Trie-based model... we first need a Trie.
There's good automated-test coverage in place to validate these changes, I believe, so...
@keymanapp-test-bot skip