Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/migrate controller tests to h2 #1741

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Jul 12, 2023

Will require this PR #1740 to be merged before tests pass.

close #1321

@Skraye Skraye self-assigned this Jul 12, 2023
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the impact on the test duration ?
Can you provide some numbers ?

webserver/build.gradle Outdated Show resolved Hide resolved
webserver/build.gradle Show resolved Hide resolved
@Skraye Skraye force-pushed the test/migrate-controller-tests-to-h2 branch from 82bd084 to a53148b Compare July 12, 2023 12:10
@Skraye
Copy link
Member Author

Skraye commented Jul 12, 2023

Did you check the impact on the test duration ? Can you provide some numbers ?

@loicmathieu
Well, it seems 10s faster on my machine, but I didn't try 100 times...

@Skraye Skraye requested a review from loicmathieu July 18, 2023 13:50
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p removed their request for review July 20, 2023 15:13
@Skraye Skraye force-pushed the test/migrate-controller-tests-to-h2 branch from 25aa7a6 to ecfb2f4 Compare July 21, 2023 09:26
@Skraye Skraye merged commit d1194e9 into develop Jul 21, 2023
@Skraye Skraye deleted the test/migrate-controller-tests-to-h2 branch July 21, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate webserver test from memory to H2
2 participants