-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/migrate controller tests to h2 #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check the impact on the test duration ?
Can you provide some numbers ?
webserver/src/test/java/io/kestra/webserver/controllers/BlueprintControllerTest.java
Show resolved
Hide resolved
82bd084
to
a53148b
Compare
@loicmathieu |
jdbc-h2/src/main/java/io/kestra/repository/h2/H2SettingRepository.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25aa7a6
to
ecfb2f4
Compare
Will require this PR #1740 to be merged before tests pass.
close #1321