fix(): review changes - remove primary

kestra-io · Jul 18, 2023 · 25aa7a6 · 25aa7a6
1 parent 26cf795
commit 25aa7a6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 35 deletions.
diff --git a/jdbc-h2/src/main/java/io/kestra/repository/h2/H2SettingRepository.java b/jdbc-h2/src/main/java/io/kestra/repository/h2/H2SettingRepository.java
@@ -3,13 +3,11 @@
 import io.kestra.core.models.Setting;
 import io.kestra.jdbc.repository.AbstractJdbcSettingRepository;
 import io.micronaut.context.ApplicationContext;
-import io.micronaut.context.annotation.Primary;
 import jakarta.inject.Inject;
 import jakarta.inject.Singleton;
 
 @Singleton
 @H2RepositoryEnabled
-@Primary
 public class H2SettingRepository extends AbstractJdbcSettingRepository {
     @Inject
     public H2SettingRepository(ApplicationContext applicationContext) {

diff --git a/webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerTest.java b/webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerTest.java
@@ -1,20 +1,12 @@
 package io.kestra.webserver.controllers;
 
-import io.kestra.core.models.Setting;
 import io.kestra.core.models.collectors.ExecutionUsage;
-import io.kestra.core.repositories.SettingRepositoryInterface;
 import io.kestra.webserver.controllers.h2.JdbcH2ControllerTest;
 import io.micronaut.http.client.annotation.Client;
 import io.micronaut.rxjava2.http.client.RxHttpClient;
-import io.micronaut.test.annotation.MockBean;
 import jakarta.inject.Inject;
 import org.junit.jupiter.api.Test;
 
-import javax.validation.ConstraintViolationException;
-import java.util.Collections;
-import java.util.List;
-import java.util.Optional;
-
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.notNullValue;
@@ -48,29 +40,4 @@ void executionUsage() {
         assertThat(response, notNullValue());
         // the memory executor didn't support daily statistics so we cannot have real execution usage
     }
-
-    @MockBean
-    SettingRepositoryInterface settingRepository() {
-        return new SettingRepositoryInterface() {
-            @Override
-            public Optional<Setting> findByKey(String key) {
-                return Optional.empty();
-            }
-
-            @Override
-            public List<Setting> findAll() {
-                return Collections.emptyList();
-            }
-
-            @Override
-            public Setting save(Setting setting) throws ConstraintViolationException {
-                return setting;
-            }
-
-            @Override
-            public Setting delete(Setting setting) {
-                return setting;
-            }
-        };
-    }
 }