-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Backbone
base class
#621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
requested changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This will be a nice change. Left some comments.
mattdangerw
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
mattdangerw
reviewed
Jan 4, 2023
mattdangerw
reviewed
Jan 4, 2023
Merged
New """Instantiate BertBackbone model from preset architecture and weights.
Args:
preset: string. Must be one of "bert_tiny_en_uncased", "bert_small_en_uncased", "bert_medium_en_uncased", "bert_base_en_uncased", "bert_base_en", "bert_base_zh", "bert_base_multi", "bert_large_en_uncased", "bert_large_en".
load_weights: Whether to load pre-trained weights into model.
Defaults to `True`.
Examples:
```python
# Load architecture and weights from preset
model = BertBackbone.from_preset("bert_base_en_uncased")
# Load randomly initialized model from preset architecture
model = BertBackbone.from_preset(
"bert_base_en_uncased",
load_weights=False
)
```
""" |
mattdangerw
approved these changes
Jan 5, 2023
This was referenced Jan 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pilot for how base classes could improve the maintainability of our library. The
Backbone
class can be easily extended to other model types andTask
,Preprocessor
, andTokenizer
base classes can also be added.I've also simplified the
from_preset
docstring so we don't have to write a lot of custom copy for each model class. We already have all the information we need in the class docstring.Part of #530