Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Task base class #635

Closed
jbischof opened this issue Jan 5, 2023 · 2 comments · Fixed by #671
Closed

Create Task base class #635

jbischof opened this issue Jan 5, 2023 · 2 comments · Fixed by #671
Assignees
Labels
stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:feature New feature or request

Comments

@jbischof
Copy link
Contributor

jbischof commented Jan 5, 2023

This PR would be an replication of #621 for task models. Actually there is more to deduplicate in this case!

Steps:

  • Create Task class in models/task.py, which inherits from PipelineModel
  • Copy over following methods/properties to base class from BertClassifier:
    • preprocess_samples
    • backbone
    • preprocessor
    • from_config
    • presets (return {})
    • from_preset with string formatting params to adapt to preset and class names
  • Remove these methods from each subclass and fill in the string params for from_preset.

Following #621, simplify the documentation for from_preset and move some of the examples to the generic constructor docstring.

@jbischof jbischof assigned jbischof and abheesht17 and unassigned jbischof Jan 5, 2023
@jbischof jbischof added type:feature New feature or request stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues labels Jan 5, 2023
@soma2000-lang
Copy link
Contributor

@jbischof Can I work on this if someone is not already into it

@jbischof
Copy link
Contributor Author

jbischof commented Jan 6, 2023

@soma2000-lang we're excited for new contributors but this task is taken. We will be adding more soon; we just emptied the queue before 0.4 release unfortunately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants