Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "Add ignoreDrainFailure and DrainTimeout as controller arguments" #305

Merged
merged 1 commit into from
Sep 3, 2021
Merged

revert "Add ignoreDrainFailure and DrainTimeout as controller arguments" #305

merged 1 commit into from
Sep 3, 2021

Conversation

shreyas-badiger
Copy link
Collaborator

Supporting drainTimeout and ignoreDrainFailure through command line arguments, needs more detailed approach. Hence reverting the previous PR #300 for now.

Signed-off-by: sbadiger <[email protected]>
@shreyas-badiger shreyas-badiger changed the title revert #300 revert Add ignoreDrainFailure and DrainTimeout as controller arguments Sep 3, 2021
@shreyas-badiger shreyas-badiger changed the title revert Add ignoreDrainFailure and DrainTimeout as controller arguments revert "Add ignoreDrainFailure and DrainTimeout as controller arguments" Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #305 (ca5cf76) into controller-v2 (df08ab0) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                Coverage Diff                @@
##           controller-v2     #305      +/-   ##
=================================================
- Coverage          39.17%   39.08%   -0.09%     
=================================================
  Files                  7        7              
  Lines                679      678       -1     
=================================================
- Hits                 266      265       -1     
  Misses               388      388              
  Partials              25       25              
Flag Coverage Δ
unittests 39.08% <33.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/common/utils.go 0.00% <ø> (ø)
controllers/rollingupgrade_controller.go 0.00% <ø> (ø)
controllers/upgrade.go 45.99% <33.33%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df08ab0...ca5cf76. Read the comment docs.

@shreyas-badiger shreyas-badiger merged commit 6252725 into keikoproj:controller-v2 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant