Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreDrainFailure and DrainTimeout as controller arguments #300

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Add ignoreDrainFailure and DrainTimeout as controller arguments #300

merged 1 commit into from
Aug 17, 2021

Conversation

shreyas-badiger
Copy link
Collaborator

  • unit testing
  • manual testing

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #300 (2395d2d) into controller-v2 (15007b3) will decrease coverage by 0.12%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           controller-v2     #300      +/-   ##
=================================================
- Coverage          36.80%   36.67%   -0.13%     
=================================================
  Files                  7        7              
  Lines                663      668       +5     
=================================================
+ Hits                 244      245       +1     
- Misses               401      405       +4     
  Partials              18       18              
Flag Coverage Δ
unittests 36.67% <25.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/common/utils.go 0.00% <0.00%> (ø)
controllers/rollingupgrade_controller.go 0.00% <ø> (ø)
controllers/upgrade.go 40.41% <40.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15007b3...2395d2d. Read the comment docs.

@shreyas-badiger shreyas-badiger merged commit 1e6d29d into keikoproj:controller-v2 Aug 17, 2021
@shreyas-badiger shreyas-badiger changed the title Add ignoreDrainFailure and DrainTimeout as controller arguements Add ignoreDrainFailure and DrainTimeout as controller arguments Sep 3, 2021
shreyas-badiger added a commit that referenced this pull request Sep 3, 2021
Signed-off-by: sbadiger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants