fix panic when using MixedInstancesPolicy #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## controller-v2 #298 +/- ##
=================================================
+ Coverage 36.80% 39.51% +2.71%
=================================================
Files 7 7
Lines 663 663
=================================================
+ Hits 244 262 +18
+ Misses 401 377 -24
- Partials 18 24 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Jonah Back <[email protected]>
eytan-avisror
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
LG
@shreyas-badiger would be good if we can do a hotfix with this fix
|
@eytan-avisror @shreyas-badiger any chance we could get that hotfix with this in? |
shreyas-badiger
added a commit
that referenced
this pull request
Aug 26, 2021
* Controller v2 (#289) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * update bdd for testing Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> Signed-off-by: sbadiger <[email protected]> * Controller v2 (#290) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * update bdd for testing Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> Signed-off-by: sbadiger <[email protected]> * Controller v2 (#291) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * update bdd for testing Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> Signed-off-by: sbadiger <[email protected]> * Controller v2 (#292) * #2286: removed version from metric namespace Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * update bdd for testing Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: ported bdd project from v1 Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: change cron Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: bdd changes for v2 Signed-off-by: sbadla1 <[email protected]> * #2122: added sh for dockerfile Signed-off-by: sbadla1 <[email protected]> Signed-off-by: sbadiger <[email protected]> * check for ASG's launch template version instead latest. (#293) Signed-off-by: sbadiger <[email protected]> * controller v2: Fix ci job (#295) * fix CI job * fix Makefile Signed-off-by: sbadiger <[email protected]> * Release v1.0.1 (#294) Signed-off-by: sbadiger <[email protected]> * replace launchTemplate latest string with version number (#296) Signed-off-by: sbadiger <[email protected]> * Release v1.0.2 (#297) Signed-off-by: sbadiger <[email protected]> * Add ignoreDrainFailure and DrainTimeout as controller arguements Signed-off-by: sbadiger <[email protected]> * Sequential AWS API call for setting instances to StandBy Signed-off-by: sbadiger <[email protected]> * Set Instances to StandBy in batches Signed-off-by: sbadiger <[email protected]> * Set Instances to StandBy in batches Signed-off-by: sbadiger <[email protected]> * Set Instances to StandBy in batches Signed-off-by: sbadiger <[email protected]> * Set Instances to StandBy in batches Signed-off-by: sbadiger <[email protected]> * fix: fix panic when using MixedInstancesPolicy (#298) Signed-off-by: Jonah Back <[email protected]> Signed-off-by: sbadiger <[email protected]> * fix vet errors Signed-off-by: sbadiger <[email protected]> * remove log messagE Signed-off-by: sbadiger <[email protected]> * change the logic Signed-off-by: sbadiger <[email protected]> * fix vet error Signed-off-by: sbadiger <[email protected]> * fix lint errors Signed-off-by: sbadiger <[email protected]> * add comment Signed-off-by: sbadiger <[email protected]> Co-authored-by: Sahil Badla <[email protected]> Co-authored-by: Jonah Back <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.