Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller v2: Fix ci job #295

Merged
merged 2 commits into from
Aug 5, 2021
Merged

controller v2: Fix ci job #295

merged 2 commits into from
Aug 5, 2021

Conversation

shreyas-badiger
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #295 (c44a025) into controller-v2 (52d80d9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           controller-v2     #295   +/-   ##
==============================================
  Coverage          37.02%   37.02%           
==============================================
  Files                  7        7           
  Lines                659      659           
==============================================
  Hits                 244      244           
  Misses               397      397           
  Partials              18       18           
Flag Coverage Δ
unittests 37.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d80d9...c44a025. Read the comment docs.

@shreyas-badiger shreyas-badiger merged commit 0b22e3a into keikoproj:controller-v2 Aug 5, 2021
shreyas-badiger added a commit that referenced this pull request Aug 26, 2021
* Controller v2 (#289)

* #2286: removed version from metric namespace

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* update bdd for testing

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* Controller v2 (#290)

* #2286: removed version from metric namespace

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* update bdd for testing

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* Controller v2 (#291)

* #2286: removed version from metric namespace

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* update bdd for testing

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* Controller v2 (#292)

* #2286: removed version from metric namespace

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* update bdd for testing

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: ported bdd project from v1

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: change cron

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: bdd changes for v2

Signed-off-by: sbadla1 <[email protected]>

* #2122: added sh for dockerfile

Signed-off-by: sbadla1 <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* check for ASG's launch template version instead latest. (#293)

Signed-off-by: sbadiger <[email protected]>

* controller v2: Fix ci job (#295)

* fix CI job

* fix Makefile

Signed-off-by: sbadiger <[email protected]>

* Release v1.0.1 (#294)

Signed-off-by: sbadiger <[email protected]>

* replace launchTemplate latest string with version number (#296)

Signed-off-by: sbadiger <[email protected]>

* Release v1.0.2 (#297)

Signed-off-by: sbadiger <[email protected]>

* Add ignoreDrainFailure and DrainTimeout as controller arguements

Signed-off-by: sbadiger <[email protected]>

* Sequential AWS API call for setting instances to StandBy

Signed-off-by: sbadiger <[email protected]>

* Set Instances to StandBy in batches

Signed-off-by: sbadiger <[email protected]>

* Set Instances to StandBy in batches

Signed-off-by: sbadiger <[email protected]>

* Set Instances to StandBy in batches

Signed-off-by: sbadiger <[email protected]>

* Set Instances to StandBy in batches

Signed-off-by: sbadiger <[email protected]>

* fix: fix panic when using MixedInstancesPolicy (#298)

Signed-off-by: Jonah Back <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* fix vet errors

Signed-off-by: sbadiger <[email protected]>

* remove log messagE

Signed-off-by: sbadiger <[email protected]>

* change the logic

Signed-off-by: sbadiger <[email protected]>

* fix vet error

Signed-off-by: sbadiger <[email protected]>

* fix lint errors

Signed-off-by: sbadiger <[email protected]>

* add comment

Signed-off-by: sbadiger <[email protected]>

Co-authored-by: Sahil Badla <[email protected]>
Co-authored-by: Jonah Back <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant