Fix: set use_kzg_da in block info based on RPC data
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #328. |
Problem: transactions that use blob data (`l1_da_mode` set to "BLOB" in the block) cannot be reexecuted because of incorrect gas computations. Solution: set `use_kzg_da` in the block info according to the `l1_da_mode` in the block structure.
odesenfans
force-pushed
the
od/set-use-kzg-da-in-block-info
branch
from
dd935bb to
e765996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: transactions that use blob data (
l1_da_modeset to "BLOB" inthe block) cannot be reexecuted because of incorrect gas computations.
Solution: set
use_kzg_dain the block info according to thel1_da_modein the block structure.Type
Description
Breaking changes?