Feature: support Sierra 1.6 #328
Conversation
Problem: some contracts on Sepolia are built with Sierra 1.6, which is not supported by the version of the CASM compiler we use. But bumping the version of the compiler requires bumping cairo-vm and Blockifier as well. Solution: bump everything! We now use: * cairo-vm 1.0.1 * cairo-lang 2.7.1 * blockifier 0.8.0-rc.2 With this, we can now compile any contract on Sepolia.
This function is no longer required as felt types now all rely on starknet-types-core.
This function is no longer required as felt types now all rely on starknet-types-core.
This function is no longer required as felt types now all rely on starknet-types-core.
This function is no longer required as felt types now all rely on starknet-types-core.
| @@ -1,15 +1,19 @@ | |||
| use blockifier::block::{BlockInfo, GasPrices}; | |||
| use blockifier::blockifier::block::{BlockInfo, GasPrices}; | |||
| use blockifier::bouncer::BouncerConfig; | |||
There was a problem hiding this comment.
If I understand it right, it's a mechanism used to determine how many txs can go in a block depending on different factors like gas, builtin usage, number of events etc.
| pub async fn storage_write(&self, _syscall_ptr: Relocatable) -> Result<(), HintError> { | ||
| let sys_hand = self.deprecated_syscall_handler.write().await; | ||
|
|
||
| let _ = sys_hand.exec_wrapper.execution_helper.write().await.execute_code_read_iter.next().ok_or( | ||
| HintError::SyscallError("No more storage writes available to replay".to_string().into_boxed_str()), | ||
| )?; | ||
|
|
||
| // Nothing to do |
There was a problem hiding this comment.
Why there is nothing to do here?
What happen with the logic that were before?
There was a problem hiding this comment.
Good remark! Newer versions of Blockifier now split reads and writes into two separate fields, CallInfo.storage_read_values and CallInfo.accessed_storage_keys. Before the two were merged so we had to take a value from the iterator (writes were always set to 0, the value itself has no interest) so that the read syscall could take the correct values.
Now, we can just iterate over storage_read_values in the read syscall and do nothing in the write syscall. Technically we could iterate over the accessed_storage_keys in the write syscall but there is no interest in doing that besides checking that we have an equal amount of values. It sounds a bit useless to me so I just replaced this code by a no-op.
| async fn get_storage_at_async(&self, contract_address: ContractAddress, key: StorageKey) -> StateResult<Felt252> { | ||
| let storage_key: TreeIndex = key.0.key().to_biguint(); | ||
|
|
||
| let mut ffc = self.ffc.clone(); |
There was a problem hiding this comment.
What is the motivation of this clone instead the mut reference ?
There was a problem hiding this comment.
This is because the trait now forces this method to take &self instead of &mut self. The FFC is built around an Arc<Mutex<Storage>> so we can just deal with this problem by cloning the FFC and then modifying the clone.
| @@ -68,7 +67,7 @@ pub async fn unpack_blockifier_state_async<S: Storage + Send + Sync, H: HashFunc | |||
| ) -> Result<(SharedState<S, H>, SharedState<S, H>), TreeError> { | |||
| let final_state = { | |||
| let state = blockifier_state.state.clone(); | |||
| state.apply_commitment_state_diff(blockifier_state.to_state_diff()).await? | |||
| state.apply_commitment_state_diff(blockifier_state.to_state_diff().expect("todo").into()).await? | |||
There was a problem hiding this comment.
.expect("todo") seems vague :P
There was a problem hiding this comment.
Woops, good point.
There was a problem hiding this comment.
Fixed. This function should not be there btw, this is only used in one integration test. I modified the expect message to be clearer, I'll move the function in another PR.
Problem: some contracts on Sepolia are built with Sierra 1.6, which is
not supported by the version of the CASM compiler we use. But bumping
the version of the compiler requires bumping cairo-vm and Blockifier as
well.
Solution: bump everything! We now use:
With this, we can now compile any contract on Sepolia.
Issue Number: N/A
Type
Description
Breaking changes?