Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kedro not instantiate datasets from kedro.extras.datasets #3069

Merged
merged 11 commits into from
Sep 26, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Sep 22, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Resolves #2125
Starters imports already resolved by kedro-org/kedro-starters#109

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Ahdra Merali <[email protected]>
Ahdra Merali added 9 commits September 22, 2023 21:25
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect there are tests to be updated, either in test/io/core or test/data_catalog.py (not sure where). Can you check with this?

@AhdraMeraliQB
Copy link
Contributor Author

@noklam

I expect there are tests to be updated, either in test/io/core or test/data_catalog.py (not sure where). Can you check with this?

I couldn't find any other references to kedro.extras... or kedro[...DataSet] in the codebase; test/io/test_data_cataog.py and tests/framework/cli/test_catalog.py already import from kedro_datasets as per #3057

@noklam
Copy link
Contributor

noklam commented Sep 26, 2023

@AhdraMeraliQB You are right! I was looking at the main branch accidentally, looks good to me then!

@noklam noklam self-requested a review September 26, 2023 12:44
@AhdraMeraliQB AhdraMeraliQB merged commit 92df623 into develop Sep 26, 2023
@AhdraMeraliQB AhdraMeraliQB deleted the 2125-not-instantiate-from-extras-datasets branch September 26, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants