Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kedro.extras.datasets and kedro.extras #3057

Merged
merged 16 commits into from
Sep 22, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Sep 21, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

partial #2126

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@noklam noklam force-pushed the noklam/remove-kedro-extras-datasets-2126 branch from 1b0f378 to c069871 Compare September 21, 2023 15:53
@noklam noklam closed this Sep 21, 2023
@noklam noklam force-pushed the noklam/remove-kedro-extras-datasets-2126 branch from d3e83fe to bc69878 Compare September 21, 2023 15:57
@noklam noklam reopened this Sep 21, 2023
@noklam
Copy link
Contributor Author

noklam commented Sep 21, 2023

@noklam
Copy link
Contributor Author

noklam commented Sep 21, 2023

Alright I keep getting weird files push into the repo, I will just force push this and clone a new repo.

Signed-off-by: Nok Chan <[email protected]>
@noklam noklam force-pushed the noklam/remove-kedro-extras-datasets-2126 branch from 3593655 to 9ad8429 Compare September 21, 2023 16:16
@noklam noklam changed the title Remove kedro.extras.datasets Remove kedro.extras.datasets and kedro.extras Sep 21, 2023
@noklam noklam mentioned this pull request Sep 21, 2023
@noklam noklam self-assigned this Sep 22, 2023
@noklam
Copy link
Contributor Author

noklam commented Sep 22, 2023

A separate PR to address the coverage/test problem. Noted I change coverage temporarily because we now missing some coverage as we removed the kedro.extra.datasets

@noklam noklam marked this pull request as ready for review September 22, 2023 16:10
@noklam noklam requested a review from merelcht as a code owner September 22, 2023 16:10
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@deepyaman
Copy link
Member

Maybe remove the line from https://github.com/kedro-org/kedro/blob/main/.github/PULL_REQUEST_TEMPLATE.md about datasets moving? Don't imagine people will try to add them here, if it doesn't exist.

@noklam
Copy link
Contributor Author

noklam commented Sep 22, 2023

@deepyaman will do in follow up datasets issues.

@noklam noklam requested a review from yetudada as a code owner September 22, 2023 17:05
@noklam noklam enabled auto-merge (squash) September 22, 2023 17:06
@noklam
Copy link
Contributor Author

noklam commented Sep 22, 2023

Removed the rst files and hopefully the docs build successfully.

@noklam noklam merged commit 94f26f2 into develop Sep 22, 2023
@noklam noklam deleted the noklam/remove-kedro-extras-datasets-2126 branch September 22, 2023 18:22
@astrojuanlu
Copy link
Member

Good night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants