-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kedro.extras.datasets
and kedro.extras
#3057
Conversation
1b0f378
to
c069871
Compare
d3e83fe
to
bc69878
Compare
Alright I keep getting weird files push into the repo, I will just force push this and clone a new repo. |
Signed-off-by: Nok Chan <[email protected]>
3593655
to
9ad8429
Compare
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
kedro.extras.datasets
kedro.extras.datasets
and kedro.extras
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
A separate PR to address the coverage/test problem. Noted I change |
Signed-off-by: Nok <[email protected]>
…thub.com/kedro-org/kedro into noklam/remove-kedro-extras-datasets-2126 Signed-off-by: Nok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the line from https://github.com/kedro-org/kedro/blob/main/.github/PULL_REQUEST_TEMPLATE.md about datasets moving? Don't imagine people will try to add them here, if it doesn't exist. |
@deepyaman will do in follow up datasets issues. |
Signed-off-by: Nok <[email protected]>
Removed the rst files and hopefully the docs build successfully. |
Signed-off-by: Nok <[email protected]>
…github.com/kedro-org/kedro into noklam/remove-kedro-extras-datasets-2126 Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Description
partial #2126
Development notes
kedro_datasets
for testing requirementskedro_datasets
in tests, doc change will be handled by Make sure all example code blocks for datasets are runnable #2287Checklist
RELEASE.md
file