Piltover nonce #12
Merged
Piltover nonce #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byteZorvin
commented
Aug 15, 2024
byteZorvin
commented
- This adds a testcase that deployment should fail if the message not registered on piltover
byteZorvin
changed the base branch from
withdrawal-limit-tests
to
withdrawal-tests
apoorvsadana
approved these changes
Aug 15, 2024
apoorvsadana
added a commit
that referenced
this pull request
Aug 20, 2024
* feat: initiliased testcases * admin function tests * fix: max total balance check * feat: block token test * disable limit test * feat: add failing tc for withdraw limit * fixed testcases after rebase * chore: added messaging mock * Update src/bridge/token_bridge.cairo Co-authored-by: Apoorv Sadana <[email protected]> * resolve comments * add reactivate and unblock * add reactivate and unblock * unblock tests * reactivate and unblock tests * resolved merge conflicts * restructure testcases * fix: visibility modifier * deposit tests * make them unit * make them unit * deposit flow tests * change to mock usdc address * improve: not needed to deploy usdc in while mock testing * unit testcases * add token actions restructure * migrate to latest foundry * restructure * deposit failing tc * test: happy withdraw test * chore: ran formatter * fix settlement of message * change deposit tests to use message_payloads * add assert * failing withdraw tc * cancel request * deposit with message cancels * Update tests/deposit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * resolved comments * fix consume message * reclaim testcases * fix consume message check * consume message * add balance check * add events in actions * deactivate tc * send messages tc * change name * withdrawal limit tests initialised * fix build failure * remaining quota * withdrawal tests * Update src/withdrawal_limit/mock.cairo Co-authored-by: Apoorv Sadana <[email protected]> * Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * should fail if message not registered (#12) * resolve commits * Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo Co-authored-by: Apoorv Sadana <[email protected]> * move file to mocks * code repetition reduced * failing tests fixed --------- Co-authored-by: Apoorv Sadana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.