Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdrawal tests #11

Merged
merged 71 commits into from
Aug 20, 2024
Merged

Withdrawal tests #11

merged 71 commits into from
Aug 20, 2024

Conversation

byteZorvin
Copy link
Member

  • This adds withdrawal limit component tests

byteZorvin and others added 30 commits July 30, 2024 15:27
@byteZorvin
feat: initiliased testcases
2e79cf8
@byteZorvin
admin function tests
3a0db04
@byteZorvin
fix: max total balance check
a2e6ada
@byteZorvin
feat: block token test
ac258c1
@byteZorvin
disable limit test
d64eb7f
@byteZorvin
feat: add failing tc for withdraw limit
19d7fb0
@byteZorvin
fixed testcases after rebase
b84a398
@byteZorvin
chore: added messaging mock
c248850
@byteZorvin @apoorvsadana
Update src/bridge/token_bridge.cairo
7a3b3f8 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin
resolve comments
4cf51a9
@byteZorvin
add reactivate and unblock
091f4d4
@byteZorvin
add reactivate and unblock
2d9e963
@byteZorvin
Merge branch 're-enroll' of https://github.com/karnotxyz/starknet_bridge
6b49de0 
 into re-enroll
@byteZorvin
unblock tests
8523be2
@byteZorvin
reactivate and unblock tests
ab6e5fd
@byteZorvin
Merge branch 'main' into re-enroll
8ad12e7
@byteZorvin
resolved merge conflicts
3b1e08f
@byteZorvin
restructure testcases
91b4c03
@byteZorvin
fix: visibility modifier
6752ad3
@byteZorvin
deposit tests
5708aa1
@byteZorvin
make them unit
0c613d0
@byteZorvin
make them unit
0bfb32b
@byteZorvin
deposit flow tests
18690bb
@byteZorvin
change to mock usdc address
fc691b5
@byteZorvin
improve: not needed to deploy usdc in while mock testing
02205bd
@byteZorvin
Merge branch 're-enroll' into test-restructure
be74d26
@byteZorvin
unit testcases
2b285d3
@byteZorvin
resolved merge conflicts
1809796
@byteZorvin
add token actions restructure
e36df0f
@byteZorvin
Merge branch 'test-restructure' into deposit-testcases
8b48d99
apoorvsadana
apoorvsadana reviewed Aug 15, 2024
View reviewed changes
src/withdrawal_limit/mock.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/mock.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated
}


pub fn deploy_erc20(name: ByteArray, symbol: ByteArray) -> ContractAddress {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have this function in other test cases, can we not move to utils and reuse?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not find a way to import files from the tests/ folder into src/ so had to replicate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create an issue for this w/ an enhancement tag and add a todo on code as well

src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated Show resolved Hide resolved
src/withdrawal_limit/tests/withdrawal_limit_test.cairo Outdated Show resolved Hide resolved
byteZorvin and others added 11 commits August 15, 2024 17:25
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/mock.cairo
86dfa69 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo
912bc4a 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo
52c154b 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo
930aaa9 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin
should fail if message not registered (#12)
079ba0c
@byteZorvin
resolve commits
c9a13cc
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo
adf4575 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin @apoorvsadana
Update src/withdrawal_limit/tests/withdrawal_limit_test.cairo
16cac78 
Co-authored-by: Apoorv Sadana <[email protected]>
@byteZorvin
move file to mocks
cac5ff0
@byteZorvin
code repetition reduced
584607c
@byteZorvin
failing tests fixed
1e51906
@apoorvsadana apoorvsadana merged commit b753a64 into main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byteZorvin @apoorvsadana