Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when #5857

Conversation

KhalilSantana
Copy link
Contributor

@KhalilSantana KhalilSantana commented Nov 21, 2024

Cherry pick of #5840 on release-1.11.
#5840: Fix: karmada-metrics-adapter use the correct certificate when
For details on the cherry pick process, see the cherry pick requests page.

`karmadactl`: Fixed `karmada-metrics-adapter` use the incorrect certificate issue when deployed via karmadactl `init`.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.97%. Comparing base (3d1aa2f) to head (b76c049).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #5857      +/-   ##
================================================
- Coverage         30.98%   30.97%   -0.01%     
================================================
  Files               644      644              
  Lines             54259    54259              
================================================
- Hits              16810    16805       -5     
- Misses            36418    36422       +4     
- Partials           1031     1032       +1     
Flag Coverage Δ
unittests 30.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@XiShanYongYe-Chang
Copy link
Member

@KhalilSantana thanks a lot~
Can you help add the release note?

@KhalilSantana
Copy link
Contributor Author

@KhalilSantana thanks a lot~ Can you help add the release note?

Hi, I've added the release note block.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2024
@karmada-bot karmada-bot merged commit 7bf4a1e into karmada-io:release-1.11 Nov 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants