Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: karmada-metrics-adapter use the correct certificate when deploye… #5840

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

KhalilSantana
Copy link
Contributor

@KhalilSantana KhalilSantana commented Nov 19, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, karmadactl blundles its own manifest for the metrics-adapter component, which is lacking the TLS flags. Thus it generates a local self-signed certificate, which karmada-apiserver doesn't trust, therefore breaking the metrics endpoint (kubectl top node for example).

Which issue(s) this PR fixes:
Fixes #5805

Special notes for your reviewer:

NOTE: Ask asked in the #5827 PR, I'm submitting a new PR for the master branch specifically.

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed `karmada-metrics-adapter` use the incorrect certificate issue when deployed via karmadactl `init`.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 19, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.02%. Comparing base (c7bc870) to head (a259d51).
Report is 22 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5840      +/-   ##
==========================================
+ Coverage   45.56%   46.02%   +0.46%     
==========================================
  Files         658      660       +2     
  Lines       53926    53987      +61     
==========================================
+ Hits        24569    24850     +281     
+ Misses      27752    27520     -232     
- Partials     1605     1617      +12     
Flag Coverage Δ
unittests 46.02% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @chaosi-zju

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@chaosi-zju
Copy link
Member

/lgtm

@XiShanYongYe-Chang
Copy link
Member

Let's merge it.
/approve

Hi @KhalilSantana, can you help cherry-pick to the previous branch?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@karmada-bot karmada-bot merged commit 1e26af3 into karmada-io:master Nov 21, 2024
18 checks passed
@KhalilSantana
Copy link
Contributor Author

KhalilSantana commented Nov 21, 2024

@XiShanYongYe-Chang,

Hi @KhalilSantana, can you help cherry-pick to the previous branch?

Hi, of course! I'll cherry-pick this commit into the 1.11 release branch

@RainbowMango
Copy link
Member

By the way. I updated the release notes.
Please let me know if not the case.

karmada-bot added a commit that referenced this pull request Nov 22, 2024
…-upstream-release-1.10

Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
karmada-bot added a commit that referenced this pull request Nov 23, 2024
…#5840-upstream-release-1.11

Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
karmada-bot added a commit that referenced this pull request Nov 23, 2024
…-upstream-release-1.9

Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use kubectl top pods/nodes on RKE2
6 participants