-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: karmada-metrics-adapter use the correct certificate when deploye… #5840
Conversation
…d via karmadactl Signed-off-by: Khalil Santana <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
+ Coverage 45.56% 46.02% +0.46%
==========================================
Files 658 660 +2
Lines 53926 53987 +61
==========================================
+ Hits 24569 24850 +281
+ Misses 27752 27520 -232
- Partials 1605 1617 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @chaosi-zju
/lgtm |
Let's merge it. Hi @KhalilSantana, can you help cherry-pick to the previous branch? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, of course! I'll cherry-pick this commit into the 1.11 release branch |
By the way. I updated the release notes. |
…-upstream-release-1.10 Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
…#5840-upstream-release-1.11 Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
…-upstream-release-1.9 Automated cherry pick of #5840: Fix: karmada-metrics-adapter use the correct certificate when
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, karmadactl blundles its own manifest for the metrics-adapter component, which is lacking the TLS flags. Thus it generates a local self-signed certificate, which karmada-apiserver doesn't trust, therefore breaking the metrics endpoint (
kubectl top node
for example).Which issue(s) this PR fixes:
Fixes #5805
Special notes for your reviewer:
NOTE: Ask asked in the #5827 PR, I'm submitting a new PR for the master branch specifically.
Does this PR introduce a user-facing change?: