Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair the test for rb status controller #5324

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

repair the test for rb status controller:

In the UT of RBStatusController, here is a fake client, as:

c.Client = fake.NewClientBuilder().WithScheme(gclient.NewSchema()).Build(),

the ut function wants to preset some resource by the fake client, such as:

if err := c.Client.Create(context.Background(), binding); err != nil {
    t.Fatalf("Failed to create binding: %v", err)
}

then it wants to update the status of that resource, such as:

if err := c.Client.Status().Update(context.Background(), binding); err != nil {
    t.Fatalf("Failed to update status of binding: %v", err)
}

Actually, the update function will failed with Error: resourcebindings.work.karmada.io "binding" not found.

the preset resource doesn't have subresource status, so update status will failed, a feasible way is like:

c.Client = fake.NewClientBuilder().WithScheme(gclient.NewSchema()).WithObjects(binding).WithStatusSubresource(binding).Build()

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 8, 2024
@chaosi-zju
Copy link
Member Author

/cc @XiShanYongYe-Chang

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.45%. Comparing base (37dfa37) to head (16a4f42).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5324   +/-   ##
=======================================
  Coverage   28.44%   28.45%           
=======================================
  Files         632      632           
  Lines       43810    43810           
=======================================
+ Hits        12462    12464    +2     
+ Misses      30447    30446    -1     
+ Partials      901      900    -1     
Flag Coverage Δ
unittests 28.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member Author

/retest

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@karmada-bot karmada-bot merged commit 5a10d75 into karmada-io:master Aug 8, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants