-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repair the test for rb status controller #5324
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5324 +/- ##
=======================================
Coverage 28.44% 28.45%
=======================================
Files 632 632
Lines 43810 43810
=======================================
+ Hits 12462 12464 +2
+ Misses 30447 30446 -1
+ Partials 901 900 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chaosi-zju <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
repair the test for rb status controller:
In the UT of
RBStatusController
, here is a fake client, as:the ut function wants to preset some resource by the fake client, such as:
then it wants to update the status of that resource, such as:
Actually, the update function will failed with
Error: resourcebindings.work.karmada.io "binding" not found
.the preset resource doesn't have subresource
status
, so update status will failed, a feasible way is like:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: