-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image-pull-policy field for karmada-operator #4863
Add image-pull-policy field for karmada-operator #4863
Conversation
Signed-off-by: wei-chenglai <[email protected]>
Welcome @seanlaii! It looks like this is your first PR to karmada-io/karmada 🎉 |
@seanlaii Thanks a lot~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4863 +/- ##
==========================================
- Coverage 53.05% 52.98% -0.08%
==========================================
Files 250 250
Lines 20371 20421 +50
==========================================
+ Hits 10808 10820 +12
- Misses 8845 8882 +37
- Partials 718 719 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@seanlaii nice job~ /lgtm btw, we can continous to push forward #4401 to add validation of the installation method of the operatoris installed. @XiShanYongYe-Chang |
/lgtm |
/lgtm thanks for doing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask an approve from @RainbowMango
/assign @RainbowMango
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
For the API part.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
#4789
Which issue(s) this PR fixes:
Part of #4789
Special notes for your reviewer:
Does this PR introduce a user-facing change?: