-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add ci for operator installation method #4401
Conversation
c96a62f
to
9ca3562
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4401 +/- ##
==========================================
+ Coverage 53.12% 53.14% +0.01%
==========================================
Files 251 251
Lines 20417 20417
==========================================
+ Hits 10847 10851 +4
+ Misses 8856 8853 -3
+ Partials 714 713 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ask @calvin0327 to help take a look. |
/assign |
f392676
to
982eac4
Compare
@calvin0327 Thank you for the review. Any other review comments? |
982eac4
to
5b3b396
Compare
kindly ping @calvin0327 @XiShanYongYe-Chang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @liangyuanpeng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Signed-off-by: zhzhuang-zju <[email protected]>
5b3b396
to
934990e
Compare
/approve /hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liangyuanpeng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @calvin0327 |
/close |
@zhzhuang-zju: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: