-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cluster-level resource propagation pause and resume capabilities #4838
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4838 +/- ##
==========================================
+ Coverage 28.24% 28.28% +0.03%
==========================================
Files 632 632
Lines 43753 43777 +24
==========================================
+ Hits 12360 12381 +21
- Misses 30492 30493 +1
- Partials 901 903 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@XiShanYongYe-Chang What's your feeling on this PR? Should I rebase and keep it up to date or do you not see this as a feature? |
I agree with this feature. I'm currently working on this area to see if karmada can provide users with faster capabilities based on this. I'll sync when I make progress. Thanks. |
d854b00
to
bd75220
Compare
Hi @a7i, we discussed how to design the API to provide users with the resources deletion policy in #4788 (comment). This is similar to Work suspension. They both describe the synchronization behavior of resource templates in member clusters, and can be resolved in three ways. Therefore, I'd like to know your opinions on how to design the API. Thanks a lot. |
@XiShanYongYe-Chang any updates? it sounds like annotations are preferred over fields on Spec (ref)? |
That's it for now, but there's no discussion about the suspension of the work propagation. I'll continue to analyze this feature starting with the next release (i.e. next month). |
c0d7bcd
to
ef4718e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Hi @a7i thanks for your hard work. I think we can take small steps and submit PRs for each of the items you listed. Is the current completed content ready for review? |
Yes it is ready, excluding the items listed above |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for the API part.
Please assign it to me for approval if no other comments.
Signed-off-by: Amir Alavi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/cc @whitewindmills @CharlesQQ @RainbowMango
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Look forward to your feedback @whitewindmills @CharlesQQ @RainbowMango |
Created a PR for webhook validation that is rebased on top of this: #5282 Going to create another PR for work status condition and rebase on top of this |
I'll take a look ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It looks good to me.
@whitewindmills Let's move this forward, we still have time for any further comments.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ability to suspend work to ensure that changes are not being reconciled.
Which issue(s) this PR fixes:
Fixes #4688
Special notes for your reviewer:
Does this PR introduce a user-facing change?: