-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to suspend Work
#4689
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5f25e91
to
6cdea4a
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4689 +/- ##
==========================================
- Coverage 53.11% 52.73% -0.39%
==========================================
Files 250 251 +1
Lines 20351 20523 +172
==========================================
+ Hits 10810 10822 +12
- Misses 8824 8980 +156
- Partials 717 721 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We've always wanted to have this feature, but it seems to be put on hold for some reason. @RainbowMango @CharlesQQ Do you all still remember? |
Yes exactly! @CharlesQQ proposed this about two years ago at #1567, but unfortunately, it has been delayed so much. What I expected from this feature is to build a practice for gray(or blue-green) release. |
This pr only suspend work object, I think it't not enough; suspend field must be set in pp or resourceTemplate, and synced to work object. |
@CharlesQQ would you be open to reviving your PRs? |
Signed-off-by: Amir Alavi <[email protected]>
replaced by #4838 (needed to remove |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ability to suspend work to ensure that changes are not being reconciled.
Which issue(s) this PR fixes:
Fixes #4688
Special notes for your reviewer:
Does this PR introduce a user-facing change?: