Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to suspend Work #4689

Closed
wants to merge 1 commit into from
Closed

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Mar 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
Ability to suspend work to ensure that changes are not being reconciled.

Which issue(s) this PR fixes:
Fixes #4688

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ability to suspend Work to ensure that changes are not being reconciled.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a7i a7i mentioned this pull request Mar 8, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2024
@a7i a7i force-pushed the amir/work-suspend branch 2 times, most recently from 5f25e91 to 6cdea4a Compare March 8, 2024 03:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 52.73%. Comparing base (fdad87e) to head (bd027db).

Files Patch % Lines
pkg/detector/detector.go 0.00% 5 Missing ⚠️
pkg/controllers/binding/common.go 50.00% 2 Missing ⚠️
pkg/util/helper/work.go 0.00% 2 Missing ⚠️
...controllers/unifiedauth/unified_auth_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4689      +/-   ##
==========================================
- Coverage   53.11%   52.73%   -0.39%     
==========================================
  Files         250      251       +1     
  Lines       20351    20523     +172     
==========================================
+ Hits        10810    10822      +12     
- Misses       8824     8980     +156     
- Partials      717      721       +4     
Flag Coverage Δ
unittests 52.73% <44.44%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaunceyjiang
Copy link
Member

suspend Work

We've always wanted to have this feature, but it seems to be put on hold for some reason.

@RainbowMango @CharlesQQ Do you all still remember?

@RainbowMango
Copy link
Member

Yes exactly! @CharlesQQ proposed this about two years ago at #1567, but unfortunately, it has been delayed so much.
I was excited when @a7i talked about this feature at the community meeting this week, as we will have more use cases to help us build this feature.

What I expected from this feature is to build a practice for gray(or blue-green) release.

@RainbowMango RainbowMango added this to the v1.10 milestone Mar 8, 2024
@CharlesQQ
Copy link
Member

This pr only suspend work object, I think it't not enough; suspend field must be set in pp or resourceTemplate, and synced to work object.

@a7i a7i marked this pull request as draft April 2, 2024 12:18
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
@a7i
Copy link
Contributor Author

a7i commented Apr 10, 2024

@CharlesQQ would you be open to reviving your PRs?

@a7i a7i force-pushed the amir/work-suspend branch from 6cdea4a to c6d5651 Compare April 17, 2024 00:21
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@a7i a7i force-pushed the amir/work-suspend branch from c6d5651 to af9b282 Compare April 17, 2024 00:23
@a7i a7i marked this pull request as ready for review April 17, 2024 00:23
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@a7i a7i force-pushed the amir/work-suspend branch from af9b282 to 2d52b0f Compare April 17, 2024 00:25
@a7i a7i force-pushed the amir/work-suspend branch from 2d52b0f to bd027db Compare April 17, 2024 01:15
@a7i a7i closed this Apr 17, 2024
@a7i a7i deleted the amir/work-suspend branch April 17, 2024 01:42
@a7i
Copy link
Contributor Author

a7i commented Apr 17, 2024

replaced by #4838 (needed to remove / from the branch name due to golang/go#32955)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to suspend work
6 participants