-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MultiClusterService FeatureGate #4347
Add MultiClusterService FeatureGate #4347
Conversation
1ddc2c2
to
53252a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4347 +/- ##
==========================================
- Coverage 51.79% 51.79% -0.01%
==========================================
Files 243 243
Lines 24112 24112
==========================================
- Hits 12490 12488 -2
- Misses 10942 10944 +2
Partials 680 680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When I set
|
Signed-off-by: jwcesign <[email protected]>
53252a3
to
40da94f
Compare
40da94f
to
beadcaf
Compare
Signed-off-by: changzhen <[email protected]>
beadcaf
to
2dba706
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
MultiClusterService
FeatureGate to allow users to decide whether to enable MultiClusterService functionality.Which issue(s) this PR fixes:
Part of #4294
Special notes for your reviewer:
Does this PR introduce a user-facing change?: