add MultiClusterService featuregate

Signed-off-by: changzhen <[email protected]>
karmada-io · Nov 30, 2023 · beadcaf · beadcaf
1 parent 68d937e
commit beadcaf
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 458 deletions.
diff --git a/artifacts/agent/karmada-agent.yaml b/artifacts/agent/karmada-agent.yaml
@@ -32,7 +32,7 @@ spec:
             - --cluster-status-update-frequency=10s
             - --bind-address=0.0.0.0
             - --secure-port=10357
-            - --feature-gates=CustomizedClusterResourceModeling=true
+            - --feature-gates=CustomizedClusterResourceModeling=true,MultiClusterService=true
             - --v=4
           livenessProbe:
             httpGet:

diff --git a/artifacts/deploy/karmada-controller-manager.yaml b/artifacts/deploy/karmada-controller-manager.yaml
@@ -31,7 +31,7 @@ spec:
             - --secure-port=10357
             - --failover-eviction-timeout=30s
             - --controllers=*,hpaReplicasSyncer
-            - --feature-gates=PropagationPolicyPreemption=true
+            - --feature-gates=PropagationPolicyPreemption=true,MultiClusterService=true
             - --v=4
           livenessProbe:
             httpGet:

diff --git a/cmd/agent/app/agent.go b/cmd/agent/app/agent.go
@@ -48,6 +48,7 @@ import (
 	"github.com/karmada-io/karmada/pkg/controllers/mcs"
 	"github.com/karmada-io/karmada/pkg/controllers/multiclusterservice"
 	"github.com/karmada-io/karmada/pkg/controllers/status"
+	"github.com/karmada-io/karmada/pkg/features"
 	karmadaclientset "github.com/karmada-io/karmada/pkg/generated/clientset/versioned"
 	"github.com/karmada-io/karmada/pkg/karmadactl/util/apiclient"
 	"github.com/karmada-io/karmada/pkg/metrics"
@@ -390,6 +391,9 @@ func startServiceExportController(ctx controllerscontext.Context) (bool, error)
 }
 
 func startEndpointSliceCollectController(ctx controllerscontext.Context) (enabled bool, err error) {
+	if !features.FeatureGate.Enabled(features.MultiClusterService) {
+		return false, nil
+	}
 	opts := ctx.Opts
 	endpointSliceCollectController := &multiclusterservice.EndpointSliceCollectController{
 		Client:                      ctx.Mgr.GetClient(),

diff --git a/cmd/controller-manager/app/controllermanager.go b/cmd/controller-manager/app/controllermanager.go
@@ -464,6 +464,9 @@ func startServiceExportController(ctx controllerscontext.Context) (enabled bool,
 }
 
 func startEndpointSliceCollectController(ctx controllerscontext.Context) (enabled bool, err error) {
+	if !features.FeatureGate.Enabled(features.Failover) {
+		return false, nil
+	}
 	opts := ctx.Opts
 	endpointSliceCollectController := &multiclusterservice.EndpointSliceCollectController{
 		Client:                      ctx.Mgr.GetClient(),
@@ -483,6 +486,9 @@ func startEndpointSliceCollectController(ctx controllerscontext.Context) (enable
 }
 
 func startEndpointSliceDispatchController(ctx controllerscontext.Context) (enabled bool, err error) {
+	if !features.FeatureGate.Enabled(features.Failover) {
+		return false, nil
+	}
 	endpointSliceSyncController := &multiclusterservice.EndpointsliceDispatchController{
 		Client:          ctx.Mgr.GetClient(),
 		EventRecorder:   ctx.Mgr.GetEventRecorderFor(multiclusterservice.EndpointsliceDispatchControllerName),
@@ -668,6 +674,9 @@ func startHPAReplicasSyncerController(ctx controllerscontext.Context) (enabled b
 }
 
 func startMCSController(ctx controllerscontext.Context) (enabled bool, err error) {
+	if !features.FeatureGate.Enabled(features.MultiClusterService) {
+		return false, nil
+	}
 	mcsController := &multiclusterservice.MCSController{
 		Client:             ctx.Mgr.GetClient(),
 		EventRecorder:      ctx.Mgr.GetEventRecorderFor(multiclusterservice.ControllerName),

diff --git a/pkg/features/features.go b/pkg/features/features.go
@@ -37,6 +37,9 @@ const (
 
 	// PolicyPreemption indicates if high-priority PropagationPolicy/ClusterPropagationPolicy could preempt resource templates which are matched by low-priority PropagationPolicy/ClusterPropagationPolicy.
 	PolicyPreemption featuregate.Feature = "PropagationPolicyPreemption"
+
+	// MultiClusterService indicates if enable multi-cluster service function.
+	MultiClusterService featuregate.Feature = "MultiClusterService"
 )
 
 var (
@@ -50,6 +53,7 @@ var (
 		PropagateDeps:                     {Default: true, PreRelease: featuregate.Beta},
 		CustomizedClusterResourceModeling: {Default: true, PreRelease: featuregate.Beta},
 		PolicyPreemption:                  {Default: false, PreRelease: featuregate.Alpha},
+		MultiClusterService:               {Default: false, PreRelease: featuregate.Alpha},
 	}
 )