-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retain for hpa controlled Deployment resource. #4075
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chaosi-zju <[email protected]>
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4075 +/- ##
=======================================
Coverage 53.83% 53.83%
=======================================
Files 231 231
Lines 23062 23086 +24
=======================================
+ Hits 12415 12428 +13
- Misses 9970 9977 +7
- Partials 677 681 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Turn to #4078
What type of PR is this?
/kind featureWhat this PR does / why we need it:
Add the Retain operation for Deployment resources, when there are relevant HPAs in effect, keep the number of replicas in the member cluster.Which issue(s) this PR fixes:
part of #4058Special notes for your reviewer:
Test Method:same as #4064Test Report:Does this PR introduce a user-facing change?: