Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain for hpa controlled Deployment resource. #4075

Closed
wants to merge 1 commit into from

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 18, 2023

Turn to #4078


What type of PR is this?

/kind feature

What this PR does / why we need it:

Add the Retain operation for Deployment resources, when there are relevant HPAs in effect, keep the number of replicas in the member cluster.

Which issue(s) this PR fixes:

part of #4058

Special notes for your reviewer:

Test Method:same as #4064

Test Report:

image
image

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 18, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chaunceyjiang, lonelycz after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang @lonelycz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 40.74% and no project coverage change.

Comparison is base (7c76237) 53.83% compared to head (8a1582e) 53.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4075   +/-   ##
=======================================
  Coverage   53.83%   53.83%           
=======================================
  Files         231      231           
  Lines       23062    23086   +24     
=======================================
+ Hits        12415    12428   +13     
- Misses       9970     9977    +7     
- Partials      677      681    +4     
Flag Coverage Δ
unittests 53.83% <40.74%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/resourceinterpreter/default/native/default.go 0.00% <0.00%> (ø)
pkg/resourceinterpreter/default/native/retain.go 10.57% <45.83%> (+10.57%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants