Feature: Cli-flags for controlling the dumping behavior #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramaro
reviewed
Oct 5, 2022
ramaro
reviewed
Oct 5, 2022
ramaro
reviewed
Oct 5, 2022
ramaro
reviewed
Oct 5, 2022
|
LGTM! Thanks for this, merging. |
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Jan 27, 2023
The field got introduced in kapicorp/kapitan#861 and is read by Kapitan's customized PyYAML representer function for strings. We currently just set the field to `""`, but we could consider changing this to use a nicer multi-line string format for Commodore's output in the future.
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Jan 27, 2023
…` to mock Kapitan argument cache The fields got introduced in kapicorp/kapitan#861 and are read by Kapitan's customized PyYAML representer functions for strings and None values respectively. We currently just set the fields to their defaults of `""` and `False`, but we could consider changing them to use a nicer multi-line string format for Commodore's output in the future, and to emit `None` entries in YAML streams as an empty string instead of `null` which would fix intermittent issues with ArgoCD choking on Helm template outputs, if `null` documents aren't removed from the output.
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Jan 27, 2023
Fields `yaml_multiline_string_style` and `yaml_dump_null_as_empty` got introduced in kapicorp/kapitan#861 and are read by Kapitan's customized PyYAML representer functions for strings and None values respectively. We currently just set the fields to their defaults of `"double-quotes"` and `False`, but we could consider changing them to use a nicer multi-line string format for Commodore's output in the future, and to emit `None` entries in YAML streams as an empty string instead of `null` which would fix intermittent issues with ArgoCD choking on Helm template outputs, if `null` documents aren't removed from the output.
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Mar 1, 2023
Fields `yaml_multiline_string_style` and `yaml_dump_null_as_empty` got introduced in kapicorp/kapitan#861 and are read by Kapitan's customized PyYAML representer functions for strings and None values respectively. We currently just set the fields to their defaults of `"double-quotes"` and `False`, but we could consider changing them to use a nicer multi-line string format for Commodore's output in the future, and to emit `None` entries in YAML streams as an empty string instead of `null` which would fix intermittent issues with ArgoCD choking on Helm template outputs, if `null` documents aren't removed from the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Added two new CLI-flags:
--multiline-string-style [STYLE]")literal: Using|as representation (turns every newline within the string into a literal newline)folded: Using>as representation (removes single newlines within the string)double-quotes: Using"as representation (dumps newlines as\n-character in one string)--dump-null-as-emptynull)The default behavior of the PrettyDumper does not change.