Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix yaml document seperator null #844

Closed
wants to merge 9 commits into from
Closed

Feature/fix yaml document seperator null #844

wants to merge 9 commits into from

Conversation

Moep90
Copy link
Contributor

@Moep90 Moep90 commented Jul 6, 2022

Fixes issue #843

Proposed Changes

@ramaro
Copy link
Member

ramaro commented Aug 20, 2022

Hey @Moep90 sorry for the delay.

I see the intention here, but I personally make use of null in YAML when setting values to None in Kadet and honestly think that's the correct, expected behavior.

However I understand why this could be useful, so maybe we can add this as a feature behind a flag?

@MatteoVoges
Copy link
Contributor

Hey @ramaro,

I'm working on this feature for the last hours and it seems like there is a problem with the yaml-representer.
I introduced the feature as a flag but the representer is loaded before the program starts and the flags/ arguments are read just after that.

So replacing the none-type-representer at runtime won't work. I have thought of some constructor overloading for the PrettyDumper class, so that it can be instantiated with different parameters for different representers etc.

What do you suggest?

@Moep90
Copy link
Contributor Author

Moep90 commented Oct 11, 2022

fixed with #861

@Moep90 Moep90 closed this Oct 11, 2022
@Moep90 Moep90 deleted the feature/fix_yaml_document_seperator_null branch October 11, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants